-
Notifications
You must be signed in to change notification settings - Fork 0
fix: resolve bottom layout spacing, remove info page footer search, and fix unit test regression #932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix: resolve bottom layout spacing, remove info page footer search, and fix unit test regression #932
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
83235f0
feat: add account controls and operational safeguards
BigSimmo 9f6626b
fix: resolve bottom layout spacing, remove info page footer search, a…
BigSimmo 8a2169b
ci: add PR policy body sync and fix Safari reserve merge-artifact test
cursoragent 7ae4c5d
ci: sync PR policy body via existing CI workflow
cursoragent 42966df
merge: resolve main conflicts preferring PR branch feature work
cursoragent 96f9f57
ci: retrigger PR policy after description sync
cursoragent 4a61397
fix: address CodeRabbit review comments and restore CI regressions
cursoragent 150a49e
fix: restore CI format compliance and PR policy sync checkout order
cursoragent a34fdc3
fix: wire Favourites rail in ClinicalDashboard and satisfy line budget
cursoragent 02743e2
fix: restore tool-detail footer search and Safari hidden-composer res…
cursoragent cb64dd5
fix: clear service detail footer above mobile search dock
cursoragent db3a902
Merge branch 'main' into codex/supabase-database-review
BigSimmo 677b841
fix: let service detail scroll content respect mobile composer reserve
cursoragent 7e49f00
fix: clear service detail dock on mobile and address review feedback
cursoragent e5405f6
style: format detail-page favourite save messaging
cursoragent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| ## Summary | ||
|
|
||
| - Hardens administrator-only access across document, ingestion, and account APIs; adds signed-in favourites/preferences persistence; repairs mobile Safari bottom-composer spacing on Information pages; and fixes a pre-existing unit-test regression in the clinical dashboard merge-artifact guards. | ||
|
|
||
| ## Verification | ||
|
|
||
| - [x] `npm run verify:cheap` — local run on PR head: lint, typecheck, and 2892/2895 unit tests passed; 3 known failures remain in `tests/pdf-extraction-budget.test.ts` (Python/PDF fixture env); clinical-dashboard merge-artifact Safari reserve assertion fixed in this commit. | ||
| - [x] `npm run check:production-readiness` — passed locally for auth/privacy/admin-route changes. | ||
| - [x] `npm run verify:ui` — hosted Production UI gate on this PR head (UI-scoped paths include `global-search-shell`, detail pages, and `DocumentViewer`). | ||
|
|
||
| ## Risk and rollout | ||
|
|
||
| - Risk: medium — touches Supabase migrations/RLS, administrator authorization, account persistence APIs, ingestion-worker auth, and mobile layout spacing; incorrect rollout could block uploads or expose admin affordances to non-administrators (API routes remain fail-closed). | ||
| - Rollback: revert the PR commit and roll back the Supabase migrations in reverse order on the preview branch; account tables are additive and can remain without breaking reads. | ||
| - Provider or production effects: requires applying new Supabase migrations and redeploying the ingestion-worker edge function; no change to answer-generation prompts or retrieval scoring. | ||
|
|
||
| ## Clinical Governance Preflight | ||
|
|
||
| <!-- GOVERNANCE_PREFLIGHT --> | ||
|
|
||
| ## Notes | ||
|
|
||
| - Resolves bottom layout spacing and transition issues on Information pages, removes the footer search composer from Information pages, restores the back button at desktop widths, and gates administrative upload-drawer assertions in tests to match production authorization. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.