Skip to content

Remove home-page quick actions row and tidy spacing#963

Merged
BigSimmo merged 2 commits into
mainfrom
claude/home-page-spacing-x72nhf
Jul 20, 2026
Merged

Remove home-page quick actions row and tidy spacing#963
BigSimmo merged 2 commits into
mainfrom
claude/home-page-spacing-x72nhf

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Jul 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • Remove the "Search documents | Upload document" quick-actions row from the answer home empty state (AnswerEmptyState). It duplicated entry points already available in the sidebar and the daily-actions menu, and sat as a redundant third stacked row in the hero footer.
  • Tidy the resulting spacing: the footer keeps its grid gap-3, so the remaining recent-searches chips and the verification footer stay evenly spaced with no orphaned gap (verified on desktop and mobile).
  • Clean up the now-dead code left behind: the unused Search/Upload icon imports and onSearchDocuments/onUploadDocument props on AnswerEmptyState, the two props at the ClinicalDashboard call site, the .answer-quick-action* CSS rules in globals.css, and the orphaned quickActionsLabel / starters copy in ui-copy.ts.
  • Update tests: retarget the admin-gate (ui-smoke) and guest-upload boundary (ui-accessibility) tests to the surviving upload entry point (daily-actions menu → "Add document", which routes through the same openUploadDrawer admin gate) so gating coverage is preserved, and drop the visibility/tap-target assertions for the deleted buttons.

The unrelated PWA manifest "Search documents" app shortcut was intentionally left untouched.

Verification

  • npm run typecheck — passes
  • npm run lint — passes (0 warnings)
  • npx vitest run on affected suites (answer-preferences.dom.test.tsx, mobile-interaction-regressions.test.ts) — 10 passed
  • npm run verify:ui (targeted): retargeted ui-accessibility guest-upload boundary test — 1 passed; ui-smoke admin-gate tests — 2 passed
  • Visual check via Chromium on desktop (1280×900) and mobile (390×844): row removed, spacing clean, no leftover gap

Risk and rollout

  • Risk: Low — UI-only removal of a redundant home-page action row plus dead-code cleanup. No change to answer generation, retrieval, ingestion, privacy, or data access.
  • Rollback: Revert this commit to restore the quick-actions row, CSS, copy, props, and prior test assertions.
  • Provider or production effects: None

Clinical Governance Preflight

  • Source-backed claims still require linked source verification before clinical use
  • No patient-identifiable document workflow was introduced or expanded without explicit governance approval
  • Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
  • Service-role keys and private document access remain server-only
  • Demo/synthetic content remains clearly separated from real clinical sources
  • Source metadata, review status, and outdated/unknown-source behavior remain conservative
  • Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

This is a presentational-only change (removes a duplicate home-page action row and dead code, retargets tests to an equivalent existing upload entry point). It does not touch retrieval, ranking, answer generation, source rendering, document access, privacy, Supabase configuration, or the upload admin gate — so every governance property above remains as it was.

Notes

  • The upload admin gate behaviour is unchanged; only the entry point the tests exercise moved from the removed row to the daily-actions menu, which invokes the same openUploadDrawer logic.

Generated by Claude Code

Summary by CodeRabbit

  • UI Updates

    • Removed the answer home quick-action buttons for searching documents and uploading documents.
    • Recent query suggestions remain available when enabled.
    • Document uploads are now accessed through the daily actions menu.
  • Accessibility

    • Updated mobile tap-target checks to focus on the privacy and data processing link.
  • Bug Fixes

    • Updated dashboard interactions to maintain upload access and related admin-only safeguards.

Remove the "Search documents | Upload document" quick-actions row from the
answer home empty state. It duplicated entry points already reachable from
the sidebar and the daily-actions menu, and sat as a third stacked row in
the hero footer.

- Drop the quick-actions block, its now-unused Search/Upload icon imports,
  and the onSearchDocuments/onUploadDocument props from AnswerEmptyState.
  The footer keeps its grid gap-3, so the remaining recent-searches chips
  and verification footer stay evenly spaced with no orphaned gap.
- Remove the associated .answer-quick-action* CSS and the orphaned
  quickActionsLabel / starters copy.
- Drop the props at the ClinicalDashboard call site.
- Retarget the admin-gate and guest-upload tests to the surviving upload
  entry point (daily-actions menu -> "Add document") so gating coverage is
  preserved, and remove the assertions for the deleted buttons.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011gd5XCutGm1tpNDgRZew57
@supabase

supabase Bot commented Jul 20, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Changes

The answer home empty state removes inline search and upload quick actions, their copy and styling, and the corresponding component props. Upload-related tests now use the daily actions menu, while accessibility and smoke assertions are updated.

Answer home UI

Layer / File(s) Summary
Remove empty-state quick actions
src/components/clinical-dashboard/answer-status.tsx
AnswerEmptyState drops search/upload callbacks, icons, and buttons while retaining recent-query selection and privacy content.
Update answer home wiring and copy
src/components/ClinicalDashboard.tsx, src/lib/ui-copy.ts, src/app/globals.css
The dashboard invocation, empty-state copy, and quick-action styles are removed or aligned with the reduced UI.
Update UI interaction coverage
tests/answer-preferences.dom.test.tsx, tests/mobile-interaction-regressions.test.ts, tests/ui-accessibility.spec.ts, tests/ui-smoke.spec.ts
Tests use the reduced component props, focus privacy tap sizing, invoke uploads through daily actions, and remove obsolete quick-action visibility checks.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • BigSimmo/Database#798: Refactors the answer home status UI and overlaps with the removed quick-action wiring.

Suggested reviewers: copilot, claude

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely summarizes the main change: removing the home-page quick actions row and adjusting spacing.
Description check ✅ Passed The description follows the template well, with summary, verification, risk, governance, and notes sections filled in.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/home-page-spacing-x72nhf

Comment @coderabbitai help to get the list of available commands.

@BigSimmo
BigSimmo marked this pull request as ready for review July 20, 2026 07:43
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@BigSimmo
BigSimmo enabled auto-merge (squash) July 20, 2026 07:43
@BigSimmo
BigSimmo merged commit 8096d17 into main Jul 20, 2026
16 of 17 checks passed
@BigSimmo
BigSimmo deleted the claude/home-page-spacing-x72nhf branch July 20, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants