Remove home-page quick actions row and tidy spacing#963
Conversation
Remove the "Search documents | Upload document" quick-actions row from the answer home empty state. It duplicated entry points already reachable from the sidebar and the daily-actions menu, and sat as a third stacked row in the hero footer. - Drop the quick-actions block, its now-unused Search/Upload icon imports, and the onSearchDocuments/onUploadDocument props from AnswerEmptyState. The footer keeps its grid gap-3, so the remaining recent-searches chips and verification footer stay evenly spaced with no orphaned gap. - Remove the associated .answer-quick-action* CSS and the orphaned quickActionsLabel / starters copy. - Drop the props at the ClinicalDashboard call site. - Retarget the admin-gate and guest-upload tests to the surviving upload entry point (daily-actions menu -> "Add document") so gating coverage is preserved, and remove the assertions for the deleted buttons. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011gd5XCutGm1tpNDgRZew57
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
📝 WalkthroughWalkthroughChangesThe answer home empty state removes inline search and upload quick actions, their copy and styling, and the corresponding component props. Upload-related tests now use the daily actions menu, while accessibility and smoke assertions are updated. Answer home UI
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary
AnswerEmptyState). It duplicated entry points already available in the sidebar and the daily-actions menu, and sat as a redundant third stacked row in the hero footer.grid gap-3, so the remaining recent-searches chips and the verification footer stay evenly spaced with no orphaned gap (verified on desktop and mobile).Search/Uploadicon imports andonSearchDocuments/onUploadDocumentprops onAnswerEmptyState, the two props at theClinicalDashboardcall site, the.answer-quick-action*CSS rules inglobals.css, and the orphanedquickActionsLabel/starterscopy inui-copy.ts.ui-smoke) and guest-upload boundary (ui-accessibility) tests to the surviving upload entry point (daily-actions menu → "Add document", which routes through the sameopenUploadDraweradmin gate) so gating coverage is preserved, and drop the visibility/tap-target assertions for the deleted buttons.The unrelated PWA manifest "Search documents" app shortcut was intentionally left untouched.
Verification
npm run typecheck— passesnpm run lint— passes (0 warnings)npx vitest runon affected suites (answer-preferences.dom.test.tsx,mobile-interaction-regressions.test.ts) — 10 passednpm run verify:ui(targeted): retargetedui-accessibilityguest-upload boundary test — 1 passed;ui-smokeadmin-gate tests — 2 passedRisk and rollout
Clinical Governance Preflight
Clinical KB Database(sjrfecxgysukkwxsowpy)This is a presentational-only change (removes a duplicate home-page action row and dead code, retargets tests to an equivalent existing upload entry point). It does not touch retrieval, ranking, answer generation, source rendering, document access, privacy, Supabase configuration, or the upload admin gate — so every governance property above remains as it was.
Notes
openUploadDrawerlogic.Generated by Claude Code
Summary by CodeRabbit
UI Updates
Accessibility
Bug Fixes