Skip to content

🔧 CodeRabbit CI Fix: Fix failing GitHub Actions Docker and CI checks #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BigSimmo merged 1 commit into from
Jul 20, 2026
Merged

🔧 CodeRabbit CI Fix: Fix failing GitHub Actions Docker and CI checks #970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions scripts/check-client-bundle-secrets.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,12 @@ const forbiddenMarkers = [
"OPENAI_ORG_ID",
"OPENAI_PROJECT_ID",
"RAG_QUERY_HASH_SECRET",
"sb_secret_",
"sk-proj-",
"sk-svcacct-",
// Match an actual key value (prefix + key body), not a bare prefix-check
// string literal. @supabase/supabase-js ships `key.startsWith('sb_secret_')`
// client-side as of 2.110.x, which would otherwise be a false positive here.
/sb_secret_[A-Za-z0-9]/,
/sk-proj-[A-Za-z0-9]/,
/sk-svcacct-[A-Za-z0-9]/,
];

function textFiles(root) {
Expand Down Expand Up @@ -47,9 +50,11 @@ const offenders = new Map();
for (const file of [...textFiles(publicRoot), ...textFiles(clientBuildRoot)]) {
const content = readFileSync(file, "utf8");
for (const marker of forbiddenMarkers) {
if (content.includes(marker)) {
const matched = marker instanceof RegExp ? marker.test(content) : content.includes(marker);
if (matched) {
const markerLabel = marker instanceof RegExp ? marker.source : marker;
const relativePath = relative(projectRoot, file).replaceAll("\\", "/");
offenders.set(`${relativePath}\0${marker}`, { marker, relativePath });
offenders.set(`${relativePath}\0${markerLabel}`, { marker: markerLabel, relativePath });
}
}
}
Expand Down
17 changes: 17 additions & 0 deletions tests/client-secret-surface.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,23 @@ describe("client environment isolation", () => {
expect(publicResult.status).toBe(1);
expect(publicResult.stderr).toContain("public/unsafe.txt");
expect(publicResult.stderr).toContain("SUPABASE_SERVICE_ROLE_KEY");

rmSync(join(fixtureRoot, "public", "unsafe.txt"));
// @supabase/supabase-js ships a bare `key.startsWith('sb_secret_')` prefix
// check client-side; that literal alone must not trip the scanner.
writeFileSync(
join(staticRoot, "sdk-prefix-check.js"),
"const isNewApiKey = (key) => key.startsWith(\"sb_publishable_\") || key.startsWith(\"sb_secret_\");",
"utf8",
);
const prefixOnlyResult = spawnSync(process.execPath, [scannerPath], { cwd: fixtureRoot, encoding: "utf8" });
expect(prefixOnlyResult.status).toBe(0);

rmSync(join(staticRoot, "sdk-prefix-check.js"));
writeFileSync(join(staticRoot, "leaked-key.js"), "const key = 'sb_secret_abc123DEF456';", "utf8");
const leakedKeyResult = spawnSync(process.execPath, [scannerPath], { cwd: fixtureRoot, encoding: "utf8" });
expect(leakedKeyResult.status).toBe(1);
expect(leakedKeyResult.stderr).toContain(".next/static/leaked-key.js");
} finally {
rmSync(fixtureRoot, { recursive: true, force: true });
}
Expand Down