Skip to content

fix(scripts): redact matched secret values in client bundle scan output#977

Merged
BigSimmo merged 2 commits into
mainfrom
claude/pr-comment-resolution-1ew33d
Jul 20, 2026
Merged

fix(scripts): redact matched secret values in client bundle scan output#977
BigSimmo merged 2 commits into
mainfrom
claude/pr-comment-resolution-1ew33d

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Summary

  • Resolves the CodeRabbit review comment on merged PR chore(deps): bump @supabase/ssr from 0.12.0 to 0.12.3 #950 (discussion_r3613025194).
  • The sb_secret_... regex branch in scripts/check-client-bundle-secrets.mjs stored and printed the full matched secret value, so a real detection would leak the token into CI logs.
  • The raw matched value is now retained only for internal deduplication; the value stored in the offenders map and printed to CI is a masked placeholder (sb_secret_…[redacted, N chars]). Literal string markers (constant names, not secrets) are still logged verbatim.

Verification

  • node --check scripts/check-client-bundle-secrets.mjs (syntax) and npx prettier formatting
  • Verification not run: npm run verify:pr-local — change is limited to a standalone CI helper script's log-output masking with no runtime/app surface; validated the mask logic directly instead.

Risk and rollout

  • Risk: Low — output-formatting only in a build-time secret-surface scanner; detection behavior (which files/markers trigger a failure and the non-zero exit) is unchanged.
  • Rollback: Revert this commit.
  • Provider or production effects: None

Notes

  • Dedup key still uses the raw matched value so multiple distinct secrets in one file are all reported, while only the masked placeholder is ever stored or logged.

Generated by Claude Code

The sb_secret_... regex branch stored and printed the full matched secret
value, so a real detection would leak the token into CI logs. Retain the
raw value only for internal deduplication and log a masked placeholder
(prefix + length) instead.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KETidushUA4xCU38zXUG8C
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@BigSimmo, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 10 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: df634a2f-143e-4ceb-8201-6226e3ecd43d

📥 Commits

Reviewing files that changed from the base of the PR and between dcbc9e6 and 9bbc79b.

📒 Files selected for processing (1)
  • scripts/check-client-bundle-secrets.mjs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/pr-comment-resolution-1ew33d

Comment @coderabbitai help to get the list of available commands.

@supabase

supabase Bot commented Jul 20, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@BigSimmo
BigSimmo marked this pull request as ready for review July 20, 2026 09:32
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@BigSimmo
BigSimmo enabled auto-merge (squash) July 20, 2026 09:32
@BigSimmo
BigSimmo merged commit 5b46e80 into main Jul 20, 2026
16 checks passed
@BigSimmo
BigSimmo deleted the claude/pr-comment-resolution-1ew33d branch July 20, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants