feat: expand pull request review context and panel tabs - #1
Closed
maria-rcks wants to merge 3 commits into
Closed
Conversation
Author
|
Closing because this stacked follow-up was opened against the contributor fork instead of the upstream repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on
This is a stacked follow-up to pingdotgg/t3code#4849. It intentionally targets
Bil0000/t3code:feat/pull-requests-page, the source branch for that PR, rather thanmain. Merging this PR into that branch will carry these changes into pingdotgg#4849.Why
The in-app review flow had three connected gaps:
What changed
Shared diff foundations
StyledDiffCodeView, the single web adapter around Pierre'sCodeView. It keeps app styling and virtualized row measurements together so visual changes cannot silently desynchronize scrolling geometry.LocalCommentAnnotationand pull-request-only composer withDiffCommentAnnotation, shared by file previews, thread diffs, and pull request diffs.CodeViewusages through the shared adapter.Expand omitted pull request context
pullRequests.diffFileContentsRPC through contracts, authorization, WebSocket dispatch, client-runtime state, the pull request service, and provider adapters.Keep reviews in compact panel tabs
User and developer impact
Validation
6 test files passed, 47 tests passed.
Commit structure
refactor(web): share diff rendering foundationsfeat(pull-requests): expand omitted diff contextfeat(web): keep pull requests open as panel tabsBuilt with GPT-5.6 Sol via the Codex harness in T3 Code.