Documentation for findall method#236
Merged
CiaranOMara merged 4 commits intoBioJulia:masterfrom Aug 2, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
==========================================
+ Coverage 89.03% 89.07% +0.04%
==========================================
Files 30 30
Lines 2325 2325
==========================================
+ Hits 2070 2071 +1
+ Misses 255 254 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Closed
jakobnissen
requested changes
Aug 1, 2022
Member
jakobnissen
left a comment
jakobnissen
left a comment
There was a problem hiding this comment.
Thanks, just a few nitpicks
Member
Author
|
Those are good nits to get out. |
CiaranOMara
force-pushed
the
feature/findall-doc
branch
from
330649d to
b7223a1
Compare
jakobnissen
approved these changes
Aug 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
findallmethod.findallwhere possible.