Add more optimised find methods for BioSequences#331
Merged
jakobnissen merged 8 commits intoBioJulia:masterfrom Apr 27, 2025
Merged
Add more optimised find methods for BioSequences#331jakobnissen merged 8 commits intoBioJulia:masterfrom
jakobnissen merged 8 commits intoBioJulia:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #331 +/- ##
==========================================
+ Coverage 90.87% 91.87% +0.99%
==========================================
Files 31 29 -2
Lines 2400 2805 +405
==========================================
+ Hits 2181 2577 +396
- Misses 219 228 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds SIMD optimised methods for
findprevandfindnext(and therefore, by extensionfindfirstandfindlast) for the predicates!isgap,iscertain,!iscertain,isambiguousand!isambiguousfor the default alphabets for LongSequence and LongSubSeqThe purpose of these is to find e.g. regions of N's in a sequence, or find the first symbol in a long DNA sequence which is not a gap or an unambiguous symbol.
Some benchmarks for AA - nucleotide benchmarks are even better:
Before:
1.738 μs (0 allocations: 0 bytes)
39.195 μs (0 allocations: 0 bytes)
39.195 μs (0 allocations: 0 bytes)
39.205 μs (0 allocations: 0 bytes)
39.205 μs (0 allocations: 0 bytes)
After:
1.894 μs (0 allocations: 0 bytes)
3.270 μs (0 allocations: 0 bytes)
5.500 μs (0 allocations: 0 bytes)
3.240 μs (0 allocations: 0 bytes)
4.530 μs (0 allocations: 0 bytes)