Skip to content

add: BitBoxBase description codes as of 27.11.19#17

Merged
benma merged 1 commit into
BitBoxSwiss:masterfrom
0xB10C:2019-11-update-base-description-codes
Dec 4, 2019
Merged

add: BitBoxBase description codes as of 27.11.19#17
benma merged 1 commit into
BitBoxSwiss:masterfrom
0xB10C:2019-11-update-base-description-codes

Conversation

@0xB10C
Copy link
Copy Markdown
Contributor

@0xB10C 0xB10C commented Nov 27, 2019

This adds the description codes as discussed.

@benma
Copy link
Copy Markdown
Contributor

benma commented Nov 27, 2019

You linked a private doc in the commit msg (and PR description). Please remove.

@0xB10C 0xB10C force-pushed the 2019-11-update-base-description-codes branch from 860a935 to 7f7e734 Compare November 27, 2019 11:52
@NickeZ
Copy link
Copy Markdown
Collaborator

NickeZ commented Dec 3, 2019

Added to firmware

BitBoxSwiss/bitbox02-firmware#244

Comment thread api/firmware/messages/bitboxbase.proto
@0xB10C 0xB10C force-pushed the 2019-11-update-base-description-codes branch 2 times, most recently from aaef6de to 6197296 Compare December 4, 2019 11:38
@0xB10C
Copy link
Copy Markdown
Contributor Author

0xB10C commented Dec 4, 2019

Added the requested documentation and rebased on master.

This adds the description codes defined in the corresponding doc.
@0xB10C 0xB10C force-pushed the 2019-11-update-base-description-codes branch from 6197296 to 51b300b Compare December 4, 2019 13:44
@benma benma merged commit 51b300b into BitBoxSwiss:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants