Update multiple recipients page#136
Merged
GBKS merged 9 commits intoJan 15, 2025
Merged
Conversation
- created sub-folders to group related pages (e.g. design system). - moved contacts and silent payment pages to milestone 1.8 -
- Text tweaks - Added payment request mockups - Added mockup of the review screen with a tooltip
GBKS
approved these changes
Jan 15, 2025
GBKS
left a comment
Contributor
There was a problem hiding this comment.
ACK. Happy to merge this in.
There are some things I'd like to address in a follow-up:
- Clear up the use of the term "Transaction". The features is enabled by toggling "Multiple recipients". Then each recipient is called a "Transaction". The review screen is labelled "Review transaction". Let's clearly distinguish between the transaction as a whole, and recipients.
- What are the "..." options next to recipient ("Transaction 1")
- Don't think we need a QR code button for the address input. The app does not have any sort of camera and QR code scanning support.
- Also don't think we need to show the paste button when the user has already entered an address.
- The desktop "Review transaction" screen is missing the fee
- Mobile screens shows the block status icon and the settings icon - let's remove those
- The mobile "Review transaction" screen has a back button, which the desktop one does not. Let's use the mobile pattern where we navigate left/right between the input and review screens (meaning we'd get rid of the "Back to editing" button at the bottom".
- Export before signing does not seem super useful. What's a good use case?
- Do we need to distinguish between "Sign" and "Sign and broadcast"? Maybe in "..." options?
Some of those points are also relevant to the basic send flow page, so we can just tackle all that together in a new PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small update to the multiple recipients page. It adds a couple more mockups and a bit more explanatory text.