Getting started guide#20

Merged

GBKS merged 65 commits into

BitcoinDesign:masterfrom

GBKS:feature/getting-started-guide-v1

Dec 9, 2020

GBKS commented Sep 1, 2020

Contributor

Do not merge, this is a work-in-progress branch PR.

GBKS added 3 commits

August 31, 2020 12:25


          Basic file structure and some content for personal finance section

03f5b5a


          Commenting out some rougher content

45a4356


          Image clean-up

91e4478

GBKS self-assigned this

ConorOkus reviewed

View reviewed changes

guide/getting-started/1-getting-started.md Outdated

ConorOkus reviewed

View reviewed changes

guide/getting-started/1-getting-started.md Outdated

ConorOkus reviewed

View reviewed changes

guide/getting-started/11-common-user-flows.md Outdated

ConorOkus reviewed

View reviewed changes

guide/getting-started/11-common-user-flows.md Outdated

ConorOkus reviewed

View reviewed changes

guide/getting-started/12-technology-primer.md Outdated

ConorOkus reviewed

View reviewed changes

guide/getting-started/12-technology-primer.md Outdated

ConorOkus reviewed

View reviewed changes

guide/getting-started/9-personal-finance.md Outdated

ConorOkus reviewed

View reviewed changes

guide/getting-started/9-personal-finance.md Outdated

ConorOkus reviewed

View reviewed changes

guide/getting-started/9-personal-finance.md

ConorOkus reviewed

View reviewed changes

guide/getting-started/9-personal-finance.md Outdated


          First draft on bitcoin hardware

933735e

ConorOkus reviewed

View reviewed changes

guide/getting-started/14-hardware.md Outdated

GBKS and others added 6 commits

September 10, 2020 10:21


          Update guide/getting-started/11-common-user-flows.md

217c847

Co-authored-by: Conor Okus <conor.okus@hotmail.co.uk>


          Update guide/getting-started/12-technology-primer.md

47f9a90

Co-authored-by: Conor Okus <conor.okus@hotmail.co.uk>


          Update guide/getting-started/9-personal-finance.md

17aa5ef

Co-authored-by: Conor Okus <conor.okus@hotmail.co.uk>


          Update guide/getting-started/9-personal-finance.md

7a40705

Co-authored-by: Conor Okus <conor.okus@hotmail.co.uk>


          Update guide/getting-started/9-personal-finance.md

ff20ef2

Co-authored-by: Conor Okus <conor.okus@hotmail.co.uk>


          Update guide/getting-started/14-hardware.md

cfa62d7

Co-authored-by: Conor Okus <conor.okus@hotmail.co.uk>

Rspigler reviewed

View reviewed changes

guide/getting-started/12-technology-primer.md Outdated


          Mostly new content to common user flows, some other tweaks

71a478d

ConorOkus reviewed

View reviewed changes

guide/getting-started/11-common-user-flows.md Outdated

ConorOkus reviewed

View reviewed changes

guide/getting-started/14-hardware.md Outdated

GBKS and others added 4 commits

September 22, 2020 18:31


          Update guide/getting-started/11-common-user-flows.md

d995618

Co-authored-by: Conor Okus <conor.okus@hotmail.co.uk>


          User flow copy additions and image folder re-org

de0aed6

Moving all images into folders of the respective page (not just section) they appear in.
Copy added to the common user flows section and minor revisions to other sections.


          First draft on open design

2cdad0e


          Open design copy revision

9ceb3b6

GBKS and others added 5 commits

December 1, 2020 13:14


          Update guide/getting-started/open-design.md

a5df29b

Co-authored-by: Conor Okus <conor.okus@hotmail.co.uk>


          Update guide/getting-started/open-design.md

a92437a

Co-authored-by: Conor Okus <conor.okus@hotmail.co.uk>


          Update guide/getting-started/open-design.md

15c6190

Co-authored-by: Conor Okus <conor.okus@hotmail.co.uk>


          Fixing license URLs in the open design page

40a218c


          Merge branch 'feature/getting-started-guide-v1' of https://github.com…

131f551

…/GBKS/Guide into feature/getting-started-guide-v1

GBKS commented Dec 1, 2020

Contributor Author

Yeh I think that could be good, as there is quite a range now

@ConorOkus I created an issue for a page about hardware wallets to address this (at some point in the future).

GBKS marked this pull request as ready for review

December 1, 2020 12:52

GBKS changed the title ~~WIP: Getting started guide~~ Getting started guide

GBKS added 3 commits

December 1, 2020 14:03


          Image optimization

e24676b


          Added editor's notes to each page

6c6a6d1

They summarize the goal of each page and some important considerations, to help future contributors more easily understand why things are the way they are.


          Added image attributions

9b83fdd

Rspigler suggested changes

View reviewed changes

Rspigler left a comment

Grammar comments

guide/getting-started/hardware.md Outdated

guide/getting-started/software.md Outdated

Rspigler reviewed

View reviewed changes

guide/getting-started/hardware.md Outdated

danielnordh reviewed

View reviewed changes

guide/getting-started/user-research.md Outdated

GBKS added 4 commits

December 2, 2020 14:18


          Added link previews and image source links to editor's notes

177901a


          Added alt texts for images

de4c159


          Copy fixes via feedback

a6825fc


          Merge branch 'master' into feature/getting-started-guide-v1

a600e81

johnsBeharry added a commit to johnsBeharry/bitcoin-design-guide that referenced this pull request


          chore: extract style and component updates from BitcoinDesign#20

34685d3

@GBKS getting started pr contains updates to styles that would be used by other writers - while that pr is under review this PR extracts those styles so they can be available to new contributors

johnsBeharry mentioned this pull request

chore: extract latest styles and includes updates from getting started PR #65

Merged

GBKS added 2 commits

December 7, 2020 10:27


          Added new and uncompressed images

ed43009


          Merge remote-tracking branch 'upstream/master' into feature/getting-s…

84a9cde

…tarted-guide-v1

GBKS commented Dec 7, 2020

Contributor Author

Alright, the section is in good shape, although there's still a lot to refine overall. But I'd still like to merge it into the main branch for now. This will make it easier to tackle individual sections individually, and also allow for easier integration with the other sections that are being worked on (others have said that this would be helpful).

I ticked off the following pre-merge items last week:

Checked for dead links
Removed unused files
Optimized images
Added editor’s notes for each page
Added image source attribution
Added image alt texts

Could you please ACK, NACK, review, discuss, praise, tweak, improve, complain, and anything else you'd like? Bring it all.

danielnordh commented Dec 7, 2020

Contributor

ACK!
Agree that merging this will make it easier for other chapters, plus it's a great step forward overall.
Good job.

ConorOkus commented Dec 7, 2020

Collaborator

ACK, good job @GBKS

pavlenex reviewed

View reviewed changes

pavlenex left a comment

Contributor

tACK (tested locally) with just a few typos I noticed along the way.

This is impressive amount of work Christoph. There are things that can be ironed out at a later point, but I agree with overall feeling that this is needed as a foundation to kick things off.

guide/getting-started/getting-started.md Outdated

guide/getting-started/getting-started.md Outdated

GBKS and others added 2 commits

December 8, 2020 16:23


          Update guide/getting-started/getting-started.md

c7b0167

Co-authored-by: Pavlenex <pavle@pavle.org>


          Update guide/getting-started/getting-started.md

959c44c

Co-authored-by: Pavlenex <pavle@pavle.org>

johnsBeharry approved these changes

View reviewed changes

johnsBeharry left a comment

Contributor

tACK. I've been using the the tech primer, open source, why bitcoin is unique and why design for bitcoin pages in the mentorship workshops and its already proving really useful so I think getting it released gives us a good foundation to build from. Great work!

GBKS merged commit 51eacfc into BitcoinDesign:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

+2 more reviewers

Labels

None yet