Adding ⚡️ content to Designing Bitcoin Products > Personal Finance#512
Merged
pavlenex merged 17 commits intoOct 19, 2021
Merged
Conversation
GBKS
added
Copy
46 tasks
sbddesign
marked this pull request as ready for review
October 12, 2021 21:50
johnsBeharry
previously approved these changes
Oct 12, 2021
Bosch-0
reviewed
Oct 13, 2021
Bosch-0
reviewed
Oct 13, 2021
Bosch-0
left a comment
Bosch-0
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, only one comment
Co-authored-by: bosch <55287964+Bosch-0@users.noreply.github.com>
Collaborator
Author
Thanks @Bosch-0 ! I committed your suggestion and then tweaked the grammar slightly. I think the idea may be better expressed as a parenthetical. |
Co-authored-by: Johns Beharry <johns@peakshift.com>
Bosch-0
previously approved these changes
Oct 15, 2021
GBKS
requested changes
Oct 15, 2021
GBKS
left a comment
GBKS
left a comment
Contributor
There was a problem hiding this comment.
Great update, just had a few minor comments (as always :)).
Co-authored-by: Christoph Ono <chri@sto.ph>
pavlenex
previously approved these changes
Oct 18, 2021
Contributor
|
@GBKS requires your approval. My uppercase be can be committed directly so we can merge this one in. |
Co-authored-by: Pavlenex <pavle@pavle.org>
GBKS
previously approved these changes
Oct 19, 2021
GBKS
left a comment
GBKS
left a comment
Contributor
There was a problem hiding this comment.
Excellent-e! Ready to go.
Only thing to tweak would be to properly capitalize Bitcoin when the network is referenced, and not the currency (4th paragraph).
pavlenex
previously approved these changes
Oct 19, 2021
pavlenex
approved these changes
Oct 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lightning content added to Personal Finance page.
⚡️ See Deploy Preview