Skip to content

feat: added lt-LT language#112

Merged
arek-bitnoise merged 5 commits into
Bitnoise:release/v0.2.1from
abonckus:feat/language-lt-LT
Jun 28, 2024
Merged

feat: added lt-LT language#112
arek-bitnoise merged 5 commits into
Bitnoise:release/v0.2.1from
abonckus:feat/language-lt-LT

Conversation

@abonckus
Copy link
Copy Markdown
Contributor

Added Lithuanian language (lt-LT) support

image

Also changed the way dayjs locale is loaded, to avoid having multiples of if statements when the language list gets bigger

return l.id === localLang;
});
locale?.id === "en" ? dayjs.locale({ ...en }) : dayjs.locale({ ...pl });
locale && dayjs.locale(locale?.id);
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be a better way to load dayjs locale to avoid stacking if statements in the future, like I have seen on other pr's. Let me know if you want me to revert this back

@arek-bitnoise arek-bitnoise changed the base branch from master to release/v0.2.1 June 28, 2024 08:14
@arek-bitnoise arek-bitnoise self-requested a review June 28, 2024 08:48
@arek-bitnoise
Copy link
Copy Markdown
Collaborator

Looks good. Thank you for your contribution.

@arek-bitnoise arek-bitnoise merged commit 9c94d3d into Bitnoise:release/v0.2.1 Jun 28, 2024
arek-bitnoise added a commit that referenced this pull request Jun 28, 2024
* feat: added Lithuanian language localization

* fix: add missing translation

* docs: updated readme.md and development.md

---------

Co-authored-by: arek-bitnoise <arkadiusz.z@bitnoi.se>
mGasiorek998 pushed a commit that referenced this pull request Aug 20, 2024
* feat: added Lithuanian language localization

* fix: add missing translation

* docs: updated readme.md and development.md

---------

Co-authored-by: arek-bitnoise <arkadiusz.z@bitnoi.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants