Skip to content

fix: device name scroll in status bar #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamieDriver merged 1 commit into from
Mar 31, 2025
Merged

fix: device name scroll in status bar #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions main/gui.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,9 +187,6 @@ static void make_status_bar(void)
JADE_ASSERT(name_alignment != GUI_ALIGN_CENTER);
gui_make_text_font(&status_bar.title, "Jade", TFT_WHITE, GUI_TITLE_FONT);
gui_set_align(status_bar.title, name_alignment, GUI_ALIGN_MIDDLE);
#if HOME_SCREEN_DEEP_STATUS_BAR && (CONFIG_DISPLAY_WIDTH <= 280)
gui_set_text_scroll(status_bar.title, TFT_BLACK);
#endif
gui_set_parent(status_bar.title, name_parent);

// Status bar data fields for tracking updates
Expand Down Expand Up @@ -2619,3 +2616,5 @@ gui_activity_t* gui_display_splash(void)
gui_set_current_activity(act);
return act;
}

gui_view_node_t* gui_status_bar_title(void) { return status_bar.title; }
1 change: 1 addition & 0 deletions main/gui.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,7 @@ void gui_set_activity_title(gui_activity_t* activity, const char* title);

gui_activity_t* gui_current_activity(void);
gui_activity_t* gui_display_splash(void);
gui_view_node_t* gui_status_bar_title(void);

void gui_wheel_click(void);
void gui_front_click(void);
Expand Down
6 changes: 6 additions & 0 deletions main/ui/dashboard.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,12 @@ gui_activity_t* make_home_screen_activity(const char* device_name, const char* f
gui_make_activity_ex(&act, true, device_name, false);
JADE_ASSERT(act);

#if HOME_SCREEN_DEEP_STATUS_BAR && (CONFIG_DISPLAY_WIDTH <= 280)
gui_view_node_t* status_bar_title = gui_status_bar_title();
status_bar_title->activity = act;
gui_set_text_scroll(status_bar_title, TFT_BLACK);
#endif

gui_view_node_t* node;
gui_view_node_t* hsplit;

Expand Down