Skip to content

lsp: update SimplicityHL compiler to 0.6.0-rc.0#306

Draft
gerau wants to merge 1 commit intoBlockstreamResearch:masterfrom
gerau:lsp/modules-migration
Draft

lsp: update SimplicityHL compiler to 0.6.0-rc.0#306
gerau wants to merge 1 commit intoBlockstreamResearch:masterfrom
gerau:lsp/modules-migration

Conversation

@gerau
Copy link
Copy Markdown
Contributor

@gerau gerau commented Apr 29, 2026

This is necessary changes to support new interface of compiler.

@gerau gerau requested a review from delta1 as a code owner April 29, 2026 13:15
@KyrylR
Copy link
Copy Markdown
Collaborator

KyrylR commented May 7, 2026

Not sure how unresolved imports are expected to impact hover and other LSP features, but from what I can see this path now returns early when driver::Program::from_parse reports an UnknownLibrary error for a use declaration. Since that returns doc = None, the document is no longer indexed, so semantic tokens, hover, references, and completion stop working for otherwise parseable files that contain imports. Should we still create the LSP Document from the parsed program here, and report unresolved imports separately?

@gerau
Copy link
Copy Markdown
Contributor Author

gerau commented May 7, 2026

Yep, there is no support for modules in LSP right now. I'm working on this right now so probably I will build on top of this PR, so converting it to a draft for now.

@gerau gerau marked this pull request as draft May 7, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants