Skip to content

Update simplicity#90

Merged
apoelstra merged 6 commits into
BlockstreamResearch:masterfrom
uncomputable:2024-09-update-sim
Sep 28, 2024
Merged

Update simplicity#90
apoelstra merged 6 commits into
BlockstreamResearch:masterfrom
uncomputable:2024-09-update-sim

Conversation

@uncomputable
Copy link
Copy Markdown
Collaborator

@uncomputable uncomputable commented Sep 28, 2024

Bump the MSRV, update rust-simplicity and add some new CI. Add the foundations for enabling codecov for the repo.

@uncomputable
Copy link
Copy Markdown
Collaborator Author

Package ‘cargo-llvm-cov-0.6.11’ in /nix/store/1lwg74im5q4fmdk3zf5az570kixzk3vb-source/pkgs/development/tools/rust/cargo-llvm-cov/default.nix:86 is marked as broken, refusing to evaluate.

Okay, let's remove cargo-llvm-cov for now.

@uncomputable uncomputable marked this pull request as draft September 28, 2024 14:12
@uncomputable
Copy link
Copy Markdown
Collaborator Author

Drafted because of BlockstreamResearch/rust-simplicity#250

Run expensive CI after cheap CI succeeded.
`just build_features` is called by `just check`, which is called by
GitHub CI.
We can use the empty program as initializer for fields that store
CompiledProgram, such as in the web IDE.
@uncomputable uncomputable marked this pull request as ready for review September 28, 2024 15:11
@uncomputable
Copy link
Copy Markdown
Collaborator Author

Undraft, as BlockstreamResearch/rust-simplicity#250 is merged.

Copy link
Copy Markdown
Contributor

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d2f77b5 successfully ran local tests

@apoelstra apoelstra merged commit 40a9c32 into BlockstreamResearch:master Sep 28, 2024
@uncomputable uncomputable deleted the 2024-09-update-sim branch September 28, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants