de20a3b value: inline single-use private from_bits function (Andrew Poelstra) e025850 value: shortcut pruning when the types are the same (Andrew Poelstra) 843fb2b value: speed up zero (Andrew Poelstra) c22b67d value: use `has_padding` to speed up `from_compact_bits` (Andrew Poelstra) d807968 types: add `has_padding` marker to `Final` (Andrew Poelstra) 0072917 value: remove now-unused Padding trait (Andrew Poelstra) 09cdded value: implement padded bit decoding directly (Andrew Poelstra) 57da572 value: promote ValueRef to public type, use it for recursion (Andrew Poelstra) 4d4dce7 value: rename internal `as_value` function to `as_ref` (Andrew Poelstra) dcb2e81 value: add benchmark for giant product of 2^512 x 2^256 (Andrew Poelstra) b7a5ff9 rename POWERS_OF_TWO across the codebase to TWO_TWO_N (Andrew Poelstra) Pull request description: This cleans up the `Value` API by making `ValueRef` public and using it in place of the slow and redundant `Value::to_*` methods. It also renames `Tmr::POWERS_OF_TWO` which was noticed as a confusing name. It adds a `types::Final::has_padding` accessor and uses it to dramatically speed up bit decoding for values. During pruning, it notices when there is nothing to do (when pruning a value to the type that it already has) and shortcuts. Unlike #266, this one leaves the API in better shape than it was before, and should be reasonably easy to review. It hsa a lot of commits but they are all pretty small. Fixes #268 ACKs for top commit: uncomputable: ACK de20a3b Tree-SHA512: ee373e712e086ed5691fdb0c313b6ae4e2c39fc0ba5ebd1388537883734bd34674ede9ae669f291324ee42fff45a701e010a7fda4cb35c0feec57b7a1a85a8c4

Rename Tmr::POWERS_OF_TWO #268

Description

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions