Skip to content

Bump bitcoin deps and version#247

Merged
uncomputable merged 2 commits into
BlockstreamResearch:masterfrom
RCasatta:bump_deps
Oct 1, 2024
Merged

Bump bitcoin deps and version#247
uncomputable merged 2 commits into
BlockstreamResearch:masterfrom
RCasatta:bump_deps

Conversation

@RCasatta
Copy link
Copy Markdown
Contributor

@RCasatta RCasatta commented Sep 26, 2024

@RCasatta RCasatta force-pushed the bump_deps branch 13 times, most recently from 3cfdd28 to 2efba4c Compare September 26, 2024 10:43
@RCasatta
Copy link
Copy Markdown
Contributor Author

RCasatta commented Sep 26, 2024 •
edited
Loading

I am failing to making 1.58.0 happy and tired trying

I tried various cargo update with the version of Cargo-recent.lock but I failed to find the solution, then rolled back to initial state

Is there some way to simplify this?

@apoelstra
Copy link
Copy Markdown
Collaborator

apoelstra commented Sep 26, 2024 •
edited
Loading

The MSRV of rust-bitcoin is 1.63. You need to bump the MSRV here before you can upgrade rust-bitcoin.

Is there some way to simplify this?

No. You need to determine which dependencies have broken MSRV and manually try pinning various combinations of them. You can probably copy versions out of the Cargo-recent.lock file in rust-bitcoin.

@uncomputable
Copy link
Copy Markdown
Collaborator

uncomputable commented Sep 27, 2024

I bumped the MSRV in #249. It might be worth to merge #249 first and to rebase #247 into #249.

uncomputable
uncomputable reviewed Sep 27, 2024
View reviewed changes
Comment thread simpcli/Cargo.toml Outdated
@RCasatta
Copy link
Copy Markdown
Contributor Author

RCasatta commented Sep 30, 2024

rebased, all green.

I also added a commit adding a shell.nix that I used to test rust 1.63, let me know if have to remove it

@uncomputable
Copy link
Copy Markdown
Collaborator

uncomputable commented Sep 30, 2024

We would need to extend the shell.nix to make it usable for us. For instance, we require different Rust versions. Let's remove it for now.

@RCasatta
Copy link
Copy Markdown
Contributor Author

RCasatta commented Sep 30, 2024

Removed

apoelstra
apoelstra approved these changes Sep 30, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 92e0972 successfully ran local tests

@RCasatta
Copy link
Copy Markdown
Contributor Author

RCasatta commented Oct 1, 2024 •
edited
Loading

Can we have a release (when merged)?

uncomputable
uncomputable approved these changes Oct 1, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@uncomputable uncomputable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 92e0972

@uncomputable uncomputable merged commit 9eed013 into BlockstreamResearch:master Oct 1, 2024
@uncomputable
Copy link
Copy Markdown
Collaborator

uncomputable commented Oct 1, 2024

@apoelstra Let's push the new release to crates.io.

@apoelstra
Copy link
Copy Markdown
Collaborator

apoelstra commented Oct 1, 2024

Tagged and published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoelstra apoelstra apoelstra approved these changes

@uncomputable uncomputable uncomputable approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RCasatta @apoelstra @uncomputable