Laravel 11: solved doctrine and mysql (5) compatibility issues#2
Laravel 11: solved doctrine and mysql (5) compatibility issues#2omars44 wants to merge 5 commits intoBloemendaal:laravel-11from
Conversation
Bloemendaal
left a comment
Bloemendaal
left a comment
There was a problem hiding this comment.
Hi @omars44! 👋
Thank you for submitting this PR! Looks good to me, however, I think you submitted it to the wrong repository. My repository is just a fork to make it work with Laravel 11, the original repository is this one: https://github.com/grimzy/laravel-mysql-spatial
Also, you might also want to update the composer.json to doctrine dbal v4. Currently, it is still at 2.5. :)
I think it's smarter if we submit these PRs separately to the original repository so the owner can check the individual upgrades instead of a PR that updates multiple dependencies.
| $this->isColumnAllowed($geometryColumn); | ||
|
|
||
| $query->whereRaw("st_distance(`$geometryColumn`, ST_GeomFromText(?, ?, 'axis-order=long-lat')) <= ?", [ | ||
| $query->whereRaw("st_distance(`$geometryColumn`, ST_GeomFromText(?, ?)) <= ?", [ |
There was a problem hiding this comment.
I think this is for MySQL 5 compatibility, see https://dev.mysql.com/blog-archive/axis-order-in-spatial-reference-systems/
|
Hi @Bloemendaal, Its not by mistake, it's meant to be a combined effort, also to make it accessible to others, so they can directly use your repo, We can collectively submit, that's the idea, but since the source is not active, we at least have something that works. I put this PR in a hurry need to clean it up. |
omars44
changed the title
|
I see about the 2 PRs, I'll open it anyway |
|
This is valid problem in this moment |
3 participants
tested with
laravel/framework: v11.5.0
doctrine/dbal: 4.0.4