Fix crash in New Collection Wizard - #18
Merged
Merged
Conversation
A recent change on the Windows side added a field to set the text for the cancel button but didn't implement the Linux side. This fixes BL-570/BL-571.
andrew-polk
added a commit
that referenced
this pull request
Oct 9, 2014
Fix crash in New Collection Wizard
JohnThomson
added a commit
that referenced
this pull request
Jul 13, 2026
…ckout display (bugs #17, #18) Bug #18: after a teammate renamed a book (rename carried by check-in), the receiving side grew TWO local folders with one instance id. Base NewBookRenamedFrom's heuristic -- "a local folder with repo status can't be the rename source" -- assumes name-keyed status and is inverted under identity-first resolution: the old-name folder resolving by id to the renamed row is exactly what marks it as the rename source. Detection therefore always failed, the renamed book was auto-downloaded as NEW next to the old folder, and later syncs refreshed the old folder's content through its identity binding. NewBookRenamedFrom is now protected internal virtual (base body unchanged, so FolderTeamCollection behavior is byte-identical) and CloudTeamCollection overrides it with an exact instance-id comparison. The two auto-download sweeps (QueueMissingRepoBooksForBackgroundDownload, and a re-check in DownloadMissingBookInBackground after the repo-presence check) now skip repo books that are renames of existing local books; both paths are only reachable for backends with CanAutoApplyRemoteChanges (cloud). The actual folder rename still happens in the existing sync rename-from-remote pass, which is already identity-driven and needs no change. Bug #17: new/local-only books in a cloud TC displayed "checked out to" Bloom's REGISTRATION identity (e.g. John1) rather than the signed-in account, because the base status JSON stamps `who`/whoFirstName/whoSurname/currentUserName from TeamCollectionManager.CurrentUser for purely-local checkouts. AddCloudBookStatusFields now rewrites `who` to the account email (clearing the registration name parts) when it equals the base registration currentUser, and carries the account identity in currentUserName; a real repo lock's `who` (a member email) is untouched. Filter incl. all folder-TC suites: 458/458 (5 new tests). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent change on the Windows side added a field to set the text
for the cancel button but didn't implement the Linux side.
This fixes BL-570/BL-571.