[5.4] BL-12396 Guatemala branding #1

[gmartin7]

• mostly affects Credits page
• waiting on response from Chris

---

This change is 

[andrew-polk]

I know this is mostly copied from another branding/xmatter.
Anything to review in particular?

Reviewed 12 of 13 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gmartin7)

[gmartin7]

Copied some yes. We'll shortly have another branding using the same xmatter (which will get commented in the later PR w/ the second branding). Mostly review the part that has 2 logos at the top of the credits page followed by a text block under those logos.

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gmartin7)

[gmartin7]

Moved the comments I referred to above into this PR.

Reviewable status: 8 of 13 files reviewed, all discussions resolved (waiting on @andrew-polk)

[andrew-polk]

Reviewed 5 of 5 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gmartin7)

---

src/content/branding/Guatemala-RTI-GBEQT/branding.json line 32 at r3 (raw file):

            "content": "<img class='branding' src='USAID_Horiz_Spanish.svg'/>",
            "condition": "always"
        },

Is there a reason we need three slots for credits-page-branding-top? i.e. top-middle, top-left, top-right?
Can there just be a top which contains all the bits?
We're trying to just have certain slots in the xmatter which the branding can fill in. If those slots can be standard across xmatters, that's much better.
So anytime we introduce a new slot, we need to evaluate whether it is really necessary.

[gmartin7]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrew-polk)

---

src/content/branding/Guatemala-RTI-GBEQT/branding.json line 32 at r3 (raw file):

Previously, andrew-polk wrote…

Is there a reason we need three slots for credits-page-branding-top? i.e. top-middle, top-left, top-right?
Can there just be a top which contains all the bits?
We're trying to just have certain slots in the xmatter which the branding can fill in. If those slots can be standard across xmatters, that's much better.
So anytime we introduce a new slot, we need to evaluate whether it is really necessary.

Hmm... I'll have to think about that. It may be that I can get away with the one slot... and no new xmatter. The main reason for the extra xmatter was just to handle the extra slots, so... I'll look at that tomorrow.

[gmartin7]

Reviewable status: 7 of 13 files reviewed, 1 unresolved discussion (waiting on @andrew-polk)

---

src/content/branding/Guatemala-RTI-GBEQT/branding.json line 32 at r3 (raw file):

Previously, gmartin7 (Gordon Martin) wrote…

Hmm... I'll have to think about that. It may be that I can get away with the one slot... and no new xmatter. The main reason for the extra xmatter was just to handle the extra slots, so... I'll look at that tomorrow.

Rearranged things significantly. How's that?

[andrew-polk]

Reviewed 6 of 6 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gmartin7)

---

src/content/branding/Guatemala-RTI-GBEQT/branding.json line 32 at r3 (raw file):

Previously, gmartin7 (Gordon Martin) wrote…

Rearranged things significantly. How's that?

Seems to greatly simplify things. Thanks.

[andrew-polk]

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gmartin7)