This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Fix the no soma h5 morphologies#288
Merged
tomdele merged 6 commits intocleanup_morphologyHDF5from Apr 23, 2021
Merged
Conversation
Merged
asanin-epfl
approved these changes
Apr 23, 2021
Contributor
|
Could be useful to check for soma types in the new added tests, but it's up to you |
Contributor
Author
|
Good idea. I will do it. I need to rebase on your test PR anyway. |
tomdele
added a commit
that referenced
this pull request
Apr 23, 2021
* Fix the no soma h5 morphologies * wrong type for the structure * fix data again * Remove the size necessarily equal to zero. * remove cassert * Multiple sections soma
Contributor
|
What test PR? Do I have one? |
Contributor
Author
|
I meant your pytest PR |
Contributor
Author
|
Rah not PR (we merged it already) commit. |
mgeplf
added a commit
that referenced
this pull request
May 5, 2021
* make which datasets belong to which versions more clear * don't use try/catch to detect if datasets exist * try and clarify where member variables are read & saved * removed member variables _points, _pointsDims, _sections, since their locality can be kept local * fix version numbering in tests/data/h5/v1/endoplasmic-reticulum.h5 / mitochondria.h5 * Fix the no soma h5 morphologies (#288) * Add tests for somatypes * test for extra somas/out of order during traversal of sections * 100 % coverage for src/readers/morphologyHDF5.cpp * added explicit glia tests * variable rename, use static_cast Co-authored-by: tomdele <thomas.delemontex@epfl.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the no soma morphologies. The single-neurite.h5 is :