Changing the way FindBump.cmake returns libraries

[jholub15]

Right now, FindBump.cmake returns a couple of variables to be used by other people (BUMP_DIR, BUMP_LIBRARIES, BUMP_INCLUDE_DIR). What these actually return is different from what seems to be traditionally returned by the find scripts in cmake. For example, BUMP_LIBRARIES returns the path to the libraries, but not a list of libraries that can directly be added in someone's project to the linker. Boost on the other hand returns a list of the libs that can directly be added to the linker without any additional steps.

Should the FindBump.cmake script be changed to follow the bump convention or is there a reason it works the way it does?

[cnoon]

Here's what I'm doing in VIPRE and it works fine for me for any kind of build...

# Only compile if we found all the necessary libraries
if (Boost_FOUND AND BUMP_FOUND AND OSG_FOUND)

    # Add the library headers
    INCLUDE_DIRECTORIES (${Boost_INCLUDE_DIR} ${BUMP_INCLUDE_DIR} ${OSG_INCLUDE_DIR})

    # Add the libraries
    SET (TARGET_EXTERNAL_LIBRARIES ${TARGET_EXTERNAL_LIBRARIES} ${Boost_LIBRARIES} ${BUMP_LIBRARIES} ${OSG_LIBRARIES})

    # Add the OpenGL library
    SET (TARGET_EXTERNAL_LIBRARIES ${TARGET_EXTERNAL_LIBRARIES} ${OPENGL_gl_LIBRARY})

    # Add each of the libraries to the build
    FOREACH (VIPRE_LIB
            vipre
            vipreDICOM
            vipreOTS
            vipreViewer
        )

        MESSAGE("Configuring Library: " ${VIPRE_LIB})
        ADD_SUBDIRECTORY (${VIPRE_LIB})

    ENDFOREACH ()

    # Add the plugins and wrappers
    ADD_SUBDIRECTORY (vipreWrappers)

ENDIF ()

You can find that file at $VIPRE_HOME/src/CMakeLists.txt path. Take a look at how this works and see if you can figure out what you've got wrong. The Bump system works the same way as OSG if I remember right and it does work like the other libraries. The BUMP_LIBRARIES variable should return the full path to the bump lib file. It would return a list, but there's only a single lib in Bump, hence the one path.