Adjusted WooCommerce store notice positioning.#200
Merged
Conversation
jamesros161
requested review from
bwmarkle and
rramo012
and removed request for
bwmarkle
rramo012
reviewed
Jun 1, 2020
rramo012
requested changes
Jun 1, 2020
Member
rramo012
left a comment
rramo012
left a comment
There was a problem hiding this comment.
Concerns with performance of notification positioning, see comment above
jamesros161
commented
Jun 2, 2020
Contributor
Author
jamesros161
left a comment
jamesros161
left a comment
There was a problem hiding this comment.
I made the requested changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When enabling a WooCommerce store notice, by default it is absolute positioned at the top of the page. However, bgtfw has it adjusted to be absolute positioned at the bottom of the page. This is undesireable as the notice will not be seen unless someone scrolls to the bottom of the page.
This PR aims to resolve #39 , however, placing the notice at the very top of the page will ave other undesireable effects, such as covering the site logo, the menu, etc. Even if the notice was placed under the masthead, if the user has submenus, it wouldn't really look right. Placing it fixed bottom of the window is better in my opinion.
There may be a feature request in the near future to give users the ability to choose the location.