Skip to content

fix link hover preview #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesros161 merged 1 commit into from
Jun 18, 2021
Merged

fix link hover preview #415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/assets/js/customizer/typography/link-preview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export class LinkPreview {
updateStyles( prefix ) {
let css = '';
if ( false === _.isFunction( api( `${prefix}_link_color_display` ) ) || 'inherit' !== api( `${prefix}_link_color_display` )() ) {
let linkColor = this._getColor( `${prefix}_link_color` ),
let linkColor = this._getColor( `${prefix}_link_color`, true ),
linkColorHover = api( `${prefix}_link_color_hover` )() || 0,
decoration = this._getDecoration( `${prefix}_link_decoration` ),
decorationHover = this._getDecoration( `${prefix}_link_decoration_hover` ),
Expand All @@ -92,6 +92,7 @@ export class LinkPreview {
shiftedColorVal;

linkColorHover = parseInt( linkColorHover, 10 ) / 100;

shiftedColorVal = colorLib.Color( linkColor ).lightenByAmount( linkColorHover ).toCSS();

for ( let selector of selectors ) {
Expand Down Expand Up @@ -131,12 +132,13 @@ export class LinkPreview {
*
* @since 2.0.0
*
* @param {string} setting Setting Name.
* @return {string} Saved Color.
* @param {string} setting Setting Name.
* @param {bool} variable Whether to return variable or true color
* @return {string} Saved Color.
*/
_getColor( setting ) {
_getColor( setting, variable = false ) {
let color = api( setting )() || '';
return this.paletteSelector.getColor( color );
return this.paletteSelector.getColor( color, variable );
}

}