Summary
components/bot_detector/database/api_public/ contains ORM models (Player, Prediction_v1/v2, PredictionFeedback, Label, Report) that are API-specific query/view shapes used only by the api_public base.
The database component should be table/query/service oriented by feature (player, prediction, report, etc.), not by which API consumes it. Having an api_public subdirectory in the database component couples persistence to transport.
Proposed Change
- Move each model into its existing feature sub-component under
database/ (e.g. prediction models into database/prediction/, report models into database/report/, etc.)
- Remove the
database/api_public/ directory entirely
- ensure feature parity
Summary
components/bot_detector/database/api_public/contains ORM models (Player, Prediction_v1/v2, PredictionFeedback, Label, Report) that are API-specific query/view shapes used only by theapi_publicbase.The database component should be table/query/service oriented by feature (player, prediction, report, etc.), not by which API consumes it. Having an
api_publicsubdirectory in the database component couples persistence to transport.Proposed Change
database/(e.g. prediction models intodatabase/prediction/, report models intodatabase/report/, etc.)database/api_public/directory entirely