Skip to content

Bridge Connection#28

Merged
AndiLavera merged 74 commits into
masterfrom
bridge-connection
Nov 24, 2020
Merged

Bridge Connection#28
AndiLavera merged 74 commits into
masterfrom
bridge-connection

Conversation

@AndiLavera

@AndiLavera AndiLavera commented Nov 21, 2020

Copy link
Copy Markdown
Collaborator

This is the PR we have all been waiting for. This is the main functionality of our application. This builds onto #23 & #24 so they can be closed.

Check List:

  • Sidekiq EventWorker
  • Sending HTTP Requests
  • Saving requests & responses in a formatted manner
  • Error handling & saving said error
  • Parsing user defined payloads with our custom syntax
  • Parsing user defined headers accessing environment variables
  • Deconstructing request headers & removing sensitive values prior to saving
  • Specs

Changes

Dependencies

  • sidekiq - Job Runner
  • redis - Sidekiq needs
  • Webmock - Mock api requests
  • Factory Bot - Better object creation for specs

Columns

  • Bridge#method => Bridge#http_method - Reason: method is a protected name in factory bot and presumably other gems/libs. http_method is also more descriptive. Specs were updated.

Routes

  • EventsController
    • Index
    • Show
    • Create
    • Destroy

This was referenced Nov 21, 2020
@AndiLavera AndiLavera changed the title WIP - Bridge Connection Bridge Connection Nov 24, 2020
@AndiLavera AndiLavera merged commit 603ed87 into master Nov 24, 2020
@AndiLavera AndiLavera mentioned this pull request Nov 25, 2020
9 tasks
@AndiLavera AndiLavera deleted the bridge-connection branch November 27, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants