GAUD-5470: List item illustration gap is too large#6716
Open
EdwinACL831 wants to merge 5 commits intomainfrom
Open
GAUD-5470: List item illustration gap is too large#6716EdwinACL831 wants to merge 5 commits intomainfrom
EdwinACL831 wants to merge 5 commits intomainfrom
Conversation
Removes the CSS rules that were overridding the --d2l-list-item-illustration-margin-inline-end from 0.9rem to 1rem This is something that we are trying to get rid off since we want the consumer to actually style the elements withing the list item
Contributor
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
…tem's grid and the d2l-list-item-content too
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
|
I think it would be worthwhile poking around to see why the nested item text didn't shift in these two cases: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira
GAUD-5470
Follow these designs
Issue
Solution
--d2l-list-item-illustration-margin-inline-endfrom0.9rem (18px)to1rem (20px). This is something that we are trying to get rid off since we want the consumer to actually style the elements withing the list item