Skip to content

add: backward compatibility for <= Xcode15 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dhvaniparekh merged 6 commits into from
Sep 30, 2024
Merged

add: backward compatibility for <= Xcode15 #23

dhvaniparekh merged 6 commits into from
Sep 30, 2024

Conversation

@Rushabhshroff
Copy link
Collaborator

@Rushabhshroff Rushabhshroff commented Sep 26, 2024

No description provided.

@Rushabhshroff Rushabhshroff self-assigned this Sep 26, 2024
@Rushabhshroff Rushabhshroff added the bug Something isn't working label Sep 26, 2024
@Rushabhshroff Rushabhshroff linked an issue Sep 26, 2024 that may be closed by this pull request
CFRunLoopSource does not convert #22
Closed
@keehoo
Copy link

keehoo commented Sep 26, 2024 •
edited
Loading

That fix didn't work for us on macos-14-xcode-15
flutter_system_proxy 0.1.5 from git https://github.com/BrowserStackCE/flutter_system_proxy at 66d28c

Failed to build iOS app
Swift Compiler Error (Xcode): Cannot convert value of type 'Unmanaged<CFRunLoopSource>' to expected argument type 'CFRunLoopSource?'
/Users/gitlab/.pub-cache/git/flutter_system_proxy-66d28cd701630468a3ffac5956160a204f05794f/ios/Classes/SwiftFlutterSystemProxyPlugin.swift:103:61

@Rushabhshroff
Copy link
Collaborator Author

Rushabhshroff commented Sep 26, 2024 •
edited
Loading

That fix didn't work for us on macos-14-xcode-15 flutter_system_proxy 0.1.5 from git https://github.com/BrowserStackCE/flutter_system_proxy at 66d28c

Failed to build iOS app
Swift Compiler Error (Xcode): Cannot convert value of type 'Unmanaged<CFRunLoopSource>' to expected argument type 'CFRunLoopSource?'
/Users/gitlab/.pub-cache/git/flutter_system_proxy-66d28cd701630468a3ffac5956160a204f05794f/ios/Classes/SwiftFlutterSystemProxyPlugin.swift:103:61

Please try again now should be fixed with b398194

ccchang0227 pushed a commit to ccchang0227/flutter_system_proxy that referenced this pull request Sep 30, 2024
Perform PR from source repo < add: backward compatibility for <= Xcod…
914ff66 
…e15 BrowserStackCE#23 >.
@dhvaniparekh dhvaniparekh merged commit c42aa85 into main Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nithyamn nithyamn nithyamn approved these changes

+1 more reviewer

@ccchang0227 ccchang0227 ccchang0227 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Rushabhshroff Rushabhshroff

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CFRunLoopSource does not convert

6 participants

@Rushabhshroff @keehoo @nithyamn @ccchang0227 @dhvaniparekh