Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
packages/nextjs/components/scaffold-eth/RainbowKitCustomConnectButton/index.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/components/scaffold-eth/RainbowKitCustomConnectButton/WrongNetworkDropdown.tsx
Show resolved
Hide resolved
packages/nextjs/components/scaffold-eth/RainbowKitCustomConnectButton/index.tsx
Outdated
Show resolved
Hide resolved
|
For some reason, I wasn't able to reproduce it :(...Like I tried opening SRE on my laptop and connecting with walletConnect from my MM mobile app and it disconnect nicely. Using: Also tried opening SRE in MM mobile app it also works expected there also from #291 (comment)
This is strange behaviour since same component is rendered in every page :( But I think the changes makes sense!! Maybe @rin-st we can also wrap the Thanks Rinat! |
For me disconnect from main page also was bugged, sometimes it worked but sometimes is not.
Thanks! Updated |
technophile-04
left a comment
There was a problem hiding this comment.
Looking great! Thanks @rin-st!!
Pabl0cks
left a comment
There was a problem hiding this comment.
I wasn't able to reproduce either :/
Disconnect was/is working nicely to me from challenge page and homepage with this setup:
- Windows laptop + Chrome
- WalletConnect with rainbow wallet on mobile (android)
- WalletConnect with safe wallet from the same laptop
There was a problem hiding this comment.
Merging this since it doesn't have side effects and also if next time something similar happens #291 we can get logs 🙌
Bug appeared because of race condition between
disconnect()andsignOut(). Changed toasyncversions and bug disappeared.Tested with WalletConnect and Metamask app on my phone (android). Note: Sometimes signing messages doesnt work if you open MM app after you click button, which requires signing. So you need to keep MM app open to successfully sign messages
Also see my comments in PR
Fixes #291
cc @escottalexander