-
Notifications
You must be signed in to change notification settings - Fork 636
Open
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomers
Description
There are a bunch of different places where comments cause the compiler to crash, because we try to JSON5 parse the given block (and comments aren't JSON5 parse-able).
Describe the bug
comments right above function declarations in useState cause endless loop/crash in Mitosis
import { useState } from "@builder.io/mitosis";
export default function MyComponent(props) {
const state = useState({
// a comment
name: 'steve',
// another comment
handleFn() {}
})
return (
<div>
<input
css={{
color: "red",
}}
value={state.name}
onChange={(event) => state.name = (event.target.value)}
/>
Hello
{name}! I can run in React, Vue, Solid, or Liquid!
</div>
);
}
If possible, a link to a https://mitosis.builder.io/ fiddle containing the bug: Fiddle causes infinite loop, so I put a code block here instead.
Expected behavior
Expect comments to be ignored/stripped before any Mitosis logic runs, and not cause any issues
Additional context
The comment above a constant property works fine, but one above a function declaration isn't
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomers
