Skip to content

updated color ID to match new tableau scheme and deleted test folder #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kentakahas merged 3 commits into from
Jun 14, 2024
Merged

updated color ID to match new tableau scheme and deleted test folder #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ab0f61
Merge pull request #35 from BuildingPerformanceSimulation/detailed_hv…
kentakahas Jun 14, 2024
2a9379e
Delete lib/measures/detailed_hvac_viewer/tests/office_chicago_pvav di…
kentakahas Jun 14, 2024
9e99574
Update report.html.erb
kentakahas Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
5 changes: 3 additions & 2 deletions lib/measures/detailed_hvac_viewer/resources/report.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,7 +673,8 @@
delete activeNodes[element.id];
element.attr('body/fill','white');
} else {
let color = getRandomColor()
const gridIndex = gridData.findIndex(obj => obj.name === element.id);
const color = getColorById(gridIndex)
activeNodes[element.id] = {"nodeName": element.id, NodeValues, color}
element.attr('body/fill', color);
}
Expand Down Expand Up @@ -1119,7 +1120,7 @@
/* END D3 MULTILINE PLOT */
function getColorById(id, colorScale = "schemeTableau10") {
// should decide on how to approach series greater than 10. generating random values above 10.
if (id > d3[colorScale].length) {
if (id > d3[colorScale].length - 1) {
return getRandomColor();
}
return d3[colorScale][id];
Expand Down
8,768 changes: 0 additions & 8,768 deletions ..._hvac_viewer/tests/office_chicago_pvav/files/USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw
View file
Open in desktop

This file was deleted.

199 changes: 0 additions & 199 deletions ..._viewer/tests/office_chicago_pvav/measures/detailed_hvac_viewer 1 1 1/README.md
View file
Open in desktop

This file was deleted.

42 changes: 0 additions & 42 deletions ...d_hvac_viewer/tests/office_chicago_pvav/measures/detailed_hvac_viewer 1 1 1/README.md.erb
View file
Open in desktop

This file was deleted.

Loading