Detailed HVAC viewer measure updates - #41
Merged
Merged
Conversation
- Add support for HVACComponents, including: - Splitter - Mixer - ThermalZone - WaterToAirComponent - WaterToWaterComponent - simplify measure.rb code to apply over loops instead of air loop and plant loops separately since the code is identical - remove before and after objects that don't exist on a loop. Some objects have connections to other nodes or equipment on other loops. We'll need to figure out how to support this. For now, remove those references. - update data schema README - update test file to include a VAV system
- Updated the network generation to work with jointJS. - gridData now contains all the information prevously in iconHash and positionHash. - Removed the grid container and replaced with jointJS paper. - Updated the measure to set the relief and outdoor nodes to be a different side to work better with the OA system component.
…ac_viewer Detailed hvac viewer
…ac_viewer-jointJS updated color ID to match new tableau scheme and deleted test folder
Added the splitter/mixers on the demand side and plots all node values.
link supply/demand inlet/outlet nodes
…ac_viewer-image_source Detailed hvac viewer image source
…eshed added comments to script added line to split demand and supply sides
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to the detailed HVAC viewer measure: