Skip to content

fix(ci): this time? #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crazycrank merged 1 commit into from
Apr 13, 2026
Merged

fix(ci): this time? #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions NuGet.config
View file
Open in desktop

This file was deleted.

8 changes: 8 additions & 0 deletions Scribe/Scribe.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,14 @@
<ItemGroup>
<None Include="..\LICENSE" Pack="true" PackagePath="" />
<None Include="..\README.md" Pack="true" PackagePath="" />
<!-- Pack LocalDev props/targets so NuGet auto-imports them for any consumer
regardless of whether the project uses Scribe.Sdk or Microsoft.NET.Sdk.
build/BulletsForHumanity.Scribe.{props,targets} are the PackageId-named
entry points NuGet auto-imports; they chain into Scribe.LocalDev.*. -->
<None Include="build\BulletsForHumanity.Scribe.props" Pack="true" PackagePath="build\" />
<None Include="build\BulletsForHumanity.Scribe.targets" Pack="true" PackagePath="build\" />
<None Include="build\Scribe.LocalDev.props" Pack="true" PackagePath="build\" />
<None Include="build\Scribe.LocalDev.targets" Pack="true" PackagePath="build\" />
Comment on lines +23 to +30

Copilot AI Apr 13, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting NuGet.config removes the repo’s only explicit local package source. Because global.json pins the MSBuild SDK BulletsForHumanity.Scribe.Sdk to a timestamped -dev.* version, dotnet restore will typically be unable to resolve the SDK from nuget.org and restores/builds will fail. Consider either (1) keeping a NuGet.config that points to a repo-local .artifacts/packages feed (and ensuring the directory exists before restore), or (2) changing global.json to reference a published SDK version so no local feed is required.

Copilot uses AI. Check for mistakes.
</ItemGroup>

<ItemGroup>
Expand Down
18 changes: 18 additions & 0 deletions Scribe/build/BulletsForHumanity.Scribe.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<Project>
<!--
NuGet auto-import entry point for the BulletsForHumanity.Scribe package.

NuGet looks for build/<PackageId>.props when a project PackageReferences
this package, and imports it early (before user targets). We chain here
into Scribe.LocalDev.props so every consumer — regardless of whether
they use the Scribe.Sdk or Microsoft.NET.Sdk — gets the LocalDev
consumer-side infrastructure (IsLocalScribe detection, additional
NuGet source registration).

$(ScribeRoot) and $(ScribesName) must be set by the consumer's
Directory.Build.props BEFORE this auto-import fires; otherwise the
file is a no-op.
Comment on lines +12 to +14

Copilot AI Apr 13, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment implies both $(ScribeRoot) and $(ScribesName) must be set by consumers for this import to do anything. In Scribe.LocalDev.props, $(ScribesName) is optional for pure consumers (it’s only needed to enable producer mode); requiring it here is misleading. Reword to indicate $(ScribeRoot) is required, and $(ScribesName) is only needed for producer projects.

Suggested change
$(ScribeRoot) and $(ScribesName) must be set by the consumer's
Directory.Build.props BEFORE this auto-import fires; otherwise the
file is a no-op.
$(ScribeRoot) must be set by the consumer's Directory.Build.props
BEFORE this auto-import fires; otherwise LocalDev consumer behavior is
effectively a no-op. $(ScribesName) is only required for producer
projects.

Copilot uses AI. Check for mistakes.
-->
<Import Project="$(MSBuildThisFileDirectory)Scribe.LocalDev.props"
Condition="Exists('$(MSBuildThisFileDirectory)Scribe.LocalDev.props')" />
</Project>
13 changes: 13 additions & 0 deletions Scribe/build/BulletsForHumanity.Scribe.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<Project>
<!--
NuGet auto-import entry point for the BulletsForHumanity.Scribe package
(late phase). Counterpart to BulletsForHumanity.Scribe.props.

Chains into Scribe.LocalDev.targets so consumers get the CPM version
override imports ($(ScribeArtifactsDir)*.Directory.Packages.targets)
and the producer-side cleanup/emit logic when this project is itself
part of a producer set.
-->
<Import Project="$(MSBuildThisFileDirectory)Scribe.LocalDev.targets"
Condition="Exists('$(MSBuildThisFileDirectory)Scribe.LocalDev.targets')" />
</Project>
2 changes: 1 addition & 1 deletion global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@
"allowPrerelease": false
},
"msbuild-sdks": {
"BulletsForHumanity.Scribe.Sdk": "0.6.2-dev.20260413-140444-648"
"BulletsForHumanity.Scribe.Sdk": "0.6.3"
}
}
Loading