perf: serialize {u,i}i128 via itoa#401
Merged
BurntSushi merged 1 commit intoBurntSushi:masterfrom Aug 18, 2025
paolobarbolini:serialize-u128-via-itoa
Merged
perf: serialize {u,i}i128 via itoa#401BurntSushi merged 1 commit intoBurntSushi:masterfrom paolobarbolini:serialize-u128-via-itoa
BurntSushi merged 1 commit intoBurntSushi:masterfrom
paolobarbolini:serialize-u128-via-itoa
Conversation
BurntSushi
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This optimizes the
serialize_i128andserialize_u128implementations by having them useitoa, as all of the other integer implementations do. This avoids going through theDisplayimplementation of u128/i128 and an intermediate allocation, which is necessary because of howcollect_stris currently implemented.The current implementation seems to be a remnant of the pre-1.0
itoadays, which didn't support u128 and i128.