Support the first 16 Ansi256 colors on Windows#10
Merged
BurntSushi merged 2 commits intoBurntSushi:masterfrom Jun 4, 2019
Merged
Support the first 16 Ansi256 colors on Windows#10BurntSushi merged 2 commits intoBurntSushi:masterfrom
BurntSushi merged 2 commits intoBurntSushi:masterfrom
Conversation
This was referenced Nov 12, 2018
|
ping @BurntSushi |
BurntSushi
requested changes
Jun 4, 2019
Owner
BurntSushi
left a comment
BurntSushi
left a comment
There was a problem hiding this comment.
Sorry, missed another long line. It's very hard to notice long lines in the diff. Please check to make sure there aren't any more in this diff.
|
Maybe you should consider adding |
Owner
|
@mati865 I'm aware of rustfmt and its ability to enforce a maximum width setting. I've considered using it, several times over the years, but rustfmt is overall not good enough. It makes way too many sub-optimal decisions. |
Owner
|
This PR is in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the issue described in rust-lang/rust#55788 (comment).