allow srcs in py_console_script_binary when using py_test as the binary#1
Draft
BurnzZ wants to merge 1 commit into
Draft
allow srcs in py_console_script_binary when using py_test as the binary#1BurnzZ wants to merge 1 commit into
py_console_script_binary when using py_test as the binary#1BurnzZ wants to merge 1 commit into
Conversation
py_console_script_binary when using py_test as the binary
4e4153f to
d609b52
Compare
d609b52 to
74419ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly just a workaround for
rules_python < 1.3.0. In bazel-contrib#2539, there was a newpython -minvocation style via themain_moduleattribute. For instance, you can directly invoke pytest inpy_testvia:However, for
rules_python < 1.3.0, we need something like this:However, when doing
bazel query 'kind("py_test", //target:test)' --output=build, thesrcsattribute ofpy_testwould only be["//target:rules_python_entry_point_test.py"].This breaks some of the other rules/macros that read the
srcsattribute of thepy_testrule, as only the entry point is exposed, not the entiresrcsof test files.