Skip to content

🎉 When selecting an OCBBlock, it is brought to the front. - #11

Merged
MathisFederico merged 2 commits into
masterfrom
feature/selected_in_front
Oct 27, 2021
Merged

🎉 When selecting an OCBBlock, it is brought to the front.#11
MathisFederico merged 2 commits into
masterfrom
feature/selected_in_front

Conversation

@vanyle

@vanyle vanyle commented Oct 27, 2021

Copy link
Copy Markdown
Contributor

It's a small cosmetic change but it's something nice to have.

It's a small cosmetic change but it's something nice to have.

@MathisFederico MathisFederico left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there a better way to bring the block on top without modifying others blocks ZValues ?

Comment thread opencodeblocks/graphics/view.py Outdated

@MathisFederico MathisFederico left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"action" is unused in this method

Comment thread opencodeblocks/graphics/view.py Outdated
@vanyle
vanyle force-pushed the feature/selected_in_front branch from 638964a to 9016152 Compare October 27, 2021 22:11

@MathisFederico MathisFederico left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect !
Thanks a lot !

@MathisFederico
MathisFederico merged commit 3b7d48f into master Oct 27, 2021
@MathisFederico
MathisFederico deleted the feature/selected_in_front branch October 27, 2021 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants