Skip to content

☔ Add unit tests to ipynb conversion - #117

Merged
MathisFederico merged 6 commits into
masterfrom
Add-ipynb-conversion-draft
Dec 19, 2021
Merged

☔ Add unit tests to ipynb conversion#117
MathisFederico merged 6 commits into
masterfrom
Add-ipynb-conversion-draft

Conversation

@FabienRoger

@FabienRoger FabienRoger commented Dec 14, 2021

Copy link
Copy Markdown
Contributor

Add tests for ipynb conversion

@FabienRoger

Copy link
Copy Markdown
Contributor Author

I think the test I added cause an out-of-memory error. I don't know how to fix it.

@FabienRoger FabienRoger changed the title features/ipynbconversion ☔ Add unit tests to ipynb conversion Dec 14, 2021

@MathisFederico MathisFederico left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't wait to merge that ! Tests are always welcome !

Comment thread tests/unit/scene/test_ipynb_conversion.py Outdated
Comment thread tests/unit/scene/test_ipynb_conversion.py Outdated
Comment thread tests/unit/scene/test_ipynb_conversion.py Outdated
Comment thread tests/unit/scene/test_ipynb_conversion.py Outdated
Comment thread tests/unit/scene/test_ipynb_conversion.py Outdated
Comment thread tests/unit/scene/test_ipynb_conversion.py Outdated
Comment thread tests/unit/scene/test_ipynb_conversion.py Outdated
Comment thread tests/unit/scene/test_ipynb_conversion.py Outdated
Comment thread tests/unit/scene/test_ipynb_conversion.py Outdated
Comment thread tests/unit/scene/test_ipynb_conversion.py Outdated

@MathisFederico MathisFederico left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect !
Thank you a lot !
Tests are always very welcome !

@MathisFederico
MathisFederico merged commit 3f28dec into master Dec 19, 2021
@MathisFederico
MathisFederico deleted the Add-ipynb-conversion-draft branch December 19, 2021 12:27
@MathisFederico
MathisFederico restored the Add-ipynb-conversion-draft branch December 19, 2021 12:27
@MathisFederico
MathisFederico deleted the Add-ipynb-conversion-draft branch December 19, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants