Feature/zoomonblocks - #91
Merged
Merged
Conversation
MathisFederico
previously approved these changes
Dec 5, 2021
MathisFederico
left a comment
MathisFederico
left a comment
Member
There was a problem hiding this comment.
Maybe a small change name and we are good to go !
| @@ -149,16 +149,23 @@ def centerView(self, x: float, y: float): | |||
| def moveToGlobalView(self) -> bool: | |||
Member
There was a problem hiding this comment.
Maybe the name is misleading now ?
Should be something like moveToItems maybe ?
MathisFederico
requested changes
Dec 6, 2021
MathisFederico
left a comment
MathisFederico
left a comment
Member
There was a problem hiding this comment.
Just need to modify docstrings accordingly, and we are good to go !
For general guidelines on how to write docstings see google python guidelines.
|
|
||
| def moveToGlobalView(self): | ||
| def moveToItems(self): | ||
| """Center the view to see the hole graph""" |
MathisFederico
approved these changes
Dec 7, 2021
MathisFederico
left a comment
MathisFederico
left a comment
Member
There was a problem hiding this comment.
A very nice contribution, thank you very much !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pressing the spacebar now zooms on selected items.