Skip to content

🎉 Functional flow execution - #98

Merged
MathisFederico merged 7 commits into
masterfrom
feature/flow_execution
Dec 6, 2021
Merged

🎉 Functional flow execution#98
MathisFederico merged 7 commits into
masterfrom
feature/flow_execution

Conversation

@AlexandreSajus

@AlexandreSajus AlexandreSajus commented Dec 6, 2021

Copy link
Copy Markdown
Contributor

A code block now has two buttons:

  • Left run: will run the block and all of its dependencies in the right order
  • Right run: will run the block's outputs and all of their dependencies in the right order

This is done through an execution queue and graph traversal utilities

Closes #48
Closes #25 executing two blocks at the same time will now create a queue

Still lacks:

  • testing (testing can be done manually using the two added examples and the modified mnist)
  • not running a cell when it has been run and was not modified

@AlexandreSajus AlexandreSajus added the enhancement New feature or request label Dec 6, 2021
@AlexandreSajus AlexandreSajus self-assigned this Dec 6, 2021

@MathisFederico MathisFederico left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add block.has_ran property and refactor

Comment thread opencodeblocks/blocks/codeblock.py Outdated
Comment thread opencodeblocks/blocks/codeblock.py Outdated
Comment thread opencodeblocks/blocks/codeblock.py Outdated
Comment thread opencodeblocks/blocks/codeblock.py Outdated
Comment thread opencodeblocks/blocks/codeblock.py Outdated
Comment thread opencodeblocks/blocks/codeblock.py Outdated
Comment thread opencodeblocks/blocks/codeblock.py Outdated
Comment thread opencodeblocks/blocks/codeblock.py
Comment thread opencodeblocks/blocks/codeblock.py
@MathisFederico
MathisFederico merged commit 21fc775 into master Dec 6, 2021
@MathisFederico
MathisFederico deleted the feature/flow_execution branch December 6, 2021 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Execution Flow Executing a block while another one is running crashes the application

2 participants