Create Token: tweaks to do #6

[BytePhoenixCoding]

Ur probably already sorting this, but just in case:

In the create token page, the approve button isn't present.

I wanted to create a token with DAI as a liquidity pair but I can't. You'll prob need some sort of check that if the base token is not BNB and it hasn't been approved for the deployer to spend, then the Approve button should be shown to the bottom left side of the screen.

Cheers.

[TG-Brad]

It should be there, seems to be for me anyway. Maybe it's already been approved and isn't showing? Though it does like I have to fix non-BNB anyway, but approval should work. Maybe try another wallet?

[BytePhoenixCoding]

In fact yeah that might be a mistake, I tried with another wallet and the approval process was perfect.

Still looks like theres a bug with actually deploying the token tho, but ur prob working on that anyway

[TG-Brad]

Yeah, I have been looking at that one and trying to figure out if it's my code or something else, it returns the error 'execution reverted: BEP20: transfer amount exceeds allowance' when you try according to the console, but BNB works fine. According to other things I've found it could be total liquidation or either just not being approved for enough. Not sure.

[BytePhoenixCoding]

That should just mean that it hasn’t been approved properly, so u haven’t approved the deployer to spend your base token. Recheck the approval probably, lmk what happens

…

On Mon, 17 Oct 2022 at 12:56, TG-Brad ***@***.***> wrote: Yeah, I have been looking at that one and trying to figure out if it's my code or something else, it returns the error 'execution reverted: BEP20: transfer amount exceeds allowance' when you try according to the console, but BNB works fine. According to other things I've found it could be total liquidation or either just not being approved for enough. Not sure. — Reply to this email directly, view it on GitHub <#33 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUWRQRTFDYFRKT33WBIJXZ3WDU5GVANCNFSM6AAAAAARG6CERI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[TG-Brad]

I'm not sure it's the approval because the swaps work though, but I'll see if I can find out what's wrong with more certainty.

[BytePhoenixCoding]

Remember that u are approving ur tokens for the deployer to spend them, not the router, idk if that’s the issue

…

On Mon, 17 Oct 2022 at 13:16, TG-Brad ***@***.***> wrote: I'm not sure it's the approval because the swaps work though, but I'll see if I can find out what's wrong with more certainty. — Reply to this email directly, view it on GitHub <#33 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUWRQRUAR6TPZC6CMJRSLFLWDU7TTANCNFSM6AAAAAARG6CERI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[TG-Brad]

Good call, you may have hit the nail on the head with that one. 👍
I imagine that'll fix it but we'll see.

[TG-Brad]

Quick update: After changing that and a few other things I went through the extent of changing your example to the new addresses to see if it was just a 'me' error or not, but on deployment both the FilterSwap and your example get the error, "execution reverted: BEP20: transfer to the zero address". If you get a sec could you give me a hand with that one? I can't tell if there's something I'm missing or it's Contract-Side.

[BytePhoenixCoding]

Quick update: After changing that and a few other things I went through the extent of changing your example to the new addresses to see if it was just a 'me' error or not, but on deployment both the FilterSwap and your example get the error, "execution reverted: BEP20: transfer to the zero address". If you get a sec could you give me a hand with that one? I can't tell if there's something I'm missing or it's Contract-Side.

So I've just had a deeper look. The create token page works flawlessly AFAICT with BNB pair, but with alt paired tokens theres an issue.

Approval is sound it seems. Problem is deploying it.

From my (limited) javascript experience, I think it might be to do with the BigNumber library (error log):

useDeployCallback.ts:141

Call threw error {parameters: {…}, contract: Contract}

Error: overflow (fault="overflow", operation="BigNumber.from", value=3000000000000000000, code=NUMERIC_FAULT, version=bignumber/5.0.13)

    at Logger.makeError (index.ts:205:1)

    at Logger.throwError (index.ts:217:1)

    at throwFault (bignumber.ts:348:1)

    at BigNumber.from (bignumber.ts:239:1)

    at NumberCoder.encode (number.ts:25:1)

    at array.ts:71:1

    at Array.forEach (<anonymous>)

    at pack (array.ts:54:1)

    at TupleCoder.encode (tuple.ts:54:1)

    at AbiCoder.encode (abi-coder.ts:112:1)

    at Interface._encodeParams (interface.ts:267:1)

    at Interface.encodeFunctionData (interface.ts:295:1)

    at index.ts:200:1

    at Generator.next (<anonymous>)

    at fulfilled (index.ts:2:1)

I put in the value '3' for 3 BUSD.

The bigNumber thing in js drives me crazy, wish they just made it easier haha.

Idk if that will put u in the right direction, update me what happens.

[TG-Brad]

Yeah, actually been meaning to look into that overflow but that might just need to be sent in hex or something if an outright int doesn't work, I think that's how swap got around that.

Even then though when you try something like 0.00003 it fails with the other error.

[BytePhoenixCoding]

Yeah I remember using hex when I did it, u can check my create token JS code to see how I did it, that may help.

…

On Tue, 18 Oct 2022 at 22:29, TG-Brad ***@***.***> wrote: Yeah, actually been meaning to look into that overflow but that might just need to be sent in hex or something if an outright int doesn't work, I think that's how swap got around that. Even then though when you try something like 0.00003 it fails with the other error. — Reply to this email directly, view it on GitHub <#33 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUWRQRUPH2TNACOLZY6NFRDWD4JDBANCNFSM6AAAAAARG6CERI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[TG-Brad]

Yeah, just tried using hex to send and I'm still getting "execution reverted: BEP20: transfer to the zero address". I've gotta roll now but I'll give it a look later. Overflow is fixed though.