fix(docs): link shared architecture/resources at root, not /python#275
Conversation
Nav, footer, and the comparison CTA pointed at /python/* paths that only exist as redirect stubs, so every click bounced to the real shared page. Architecture and resources are SDK-agnostic (Python + Node), so link their canonical root URLs directly.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThree documentation app navigation files update link ChangesNavigation URL Path Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Problem
Nav, footer, and the landing "comparison" CTA linked architecture/changelog/FAQ/comparison under
/python/*. Those/python/*paths only exist as redirect stubs (real content lives at the shared root/architecture,/resources/*), so every click bounced through a redirect to a bare-root URL — reported as architecture →/architecture, changelog →/resources/changelog.Why root is correct
Architecture and resources (changelog/FAQ/comparison) are SDK-agnostic — they apply to both the Python and Node SDKs, so they live at shared root paths, not under
/python/. This matches how multi-SDK docs (e.g. Temporal) separate language-independent concepts from per-language guides.Fix
Point the nav/footer/CTA links directly at the canonical shared root URLs — no redirect hop.
app/lib/redirects.tskeeps mapping old/python/*deep links to root for external bookmarks.site-nav.tsx: Architecture →/architecture, Changelog →/resources/changelogfooter.tsx: Architecture →/architecture; comparison/FAQ/changelog →/resources/*sections.tsx: comparison CTA →/resources/comparisonPer-SDK links (getting-started, guides, API, examples) stay
/python/*unchanged.Verify
pnpm typecheck+pnpm build+pnpm lintgreen.Summary by CodeRabbit