fix: docs topbar and inline code overflow on phones#410
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe changes refine small-screen documentation layout by tightening navigation spacing, hiding SDK picker labels at narrow widths, and allowing long code identifiers to wrap without horizontal overflow. ChangesMobile documentation layout
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On phone viewports the docs pages gained a horizontal scroll, pushing the theme and GitHub buttons in the topbar off-screen (reported on iPhone SE, 375px).
Two causes, measured with headless Chrome at 375/360/320px:
overflow-wrap: anywhere.Verification
Headless-Chrome sweep of landing, quickstart (both SDK trees), architecture, and changelog at 375/360/320px:
document.scrollWidth === clientWidthon every page (was 412 and 568 before). Screenshot check at 375px confirms all topbar controls visible with no horizontal scroll.biome checkandtypecheckgreen.Summary by CodeRabbit