refactor: seal resilience manager structs pub(crate)#464
Merged
Conversation
CircuitBreaker/RateLimiter/DeadLetterQueue serve only the in-crate Scheduler; drop the dead circuit_breaker() accessor and unused DLQ list/retry/purge.
📝 WalkthroughWalkthroughThe change narrows resilience APIs to crate-only visibility, removes unused dead-letter queue management methods, and deletes the scheduler’s public circuit-breaker accessor. Internal circuit-breaker, DLQ, and rate-limiter behavior remains unchanged. ChangesResilience API Encapsulation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The resilience manager structs are public but serve only the in-crate
Scheduler. No binding or sibling crate consumes them (bindings drive resilience throughStoragemethods directly). Seal them:CircuitBreaker(struct + methods) →pub(crate)RateLimiter(struct + methods) →pub(crate)DeadLetterQueue(struct + methods) →pub(crate)Scheduler::circuit_breaker()— dead accessor, zero callerslist/retry/purge— no in-crate caller (would tripdead_codeonce sealed)Kept public (config contract, already root-exported):
RetryPolicy,RateLimitConfig,CircuitBreakerConfig,CircuitState.Verify
All green:
cargo test --workspacecargo check --workspace --features postgres,rediscargo clippy --workspace --all-targets -- -D warningscargo doc --no-deps -p taskito-corewithRUSTDOCFLAGS=-D warningscargo publish --dry-run -p taskito-coreSummary by CodeRabbit