Skip to content

Move flexiMenu functions to CfgFunctions#1054

Closed
dedmen wants to merge 5 commits intoCBATeam:masterfrom
dedmen:sexyflexi
Closed

Move flexiMenu functions to CfgFunctions#1054
dedmen wants to merge 5 commits intoCBATeam:masterfrom
dedmen:sexyflexi

Conversation

@dedmen
Copy link
Copy Markdown
Contributor

@dedmen dedmen commented Feb 8, 2019

tracy_2019-02-08_14-30-35

This triggers me.

@commy2
Copy link
Copy Markdown
Contributor

commy2 commented Feb 8, 2019

Could delete these: https://github.com/CBATeam/CBA_A3/blob/master/addons/ui/script_component.hpp#L83-L86

However, before the functions are named cba_flexiMenu_fnc_execute, but now they are named cba_fnc_flexiMenu_execute` etc, or am I missing something?

@dedmen
Copy link
Copy Markdown
Contributor Author

dedmen commented Feb 8, 2019

Might be right yeah. But then we previously had both
https://github.com/CBATeam/CBA_A3/pull/1054/files#diff-d0bf4bd8fc69fef6ce8641586ab5da29L23
cba_flexiMenu_fnc_add and
https://github.com/CBATeam/CBA_A3/pull/1054/files#diff-1ed3566cd26e88a81c404dde0895265bR4
cba_fnc_flexuMenu_add

I guess I'll just move them to PREP then?

@commy2
Copy link
Copy Markdown
Contributor

commy2 commented Feb 8, 2019

master:
cba_ui_fnc_execute

PR:
cba_fnc_flexiMenu_execute

Comment thread addons/ui/flexiMenu/init.sqf
Comment thread addons/ui/flexiMenu/init.sqf Outdated
Copy link
Copy Markdown
Contributor

@commy2 commy2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@commy2
Copy link
Copy Markdown
Contributor

commy2 commented Feb 8, 2019

Can we also delete these silly description entries from the other functions? They do nothing.

@commy2 commy2 added this to the 3.10 milestone Feb 8, 2019
Comment thread addons/ui/flexiMenu/init.sqf Outdated
Copy link
Copy Markdown
Contributor

@commy2 commy2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allVariables missionNamespace

Before minus new (functions lost by this PR):

["cba_ui_fnc_setobjectmenusource"]

New minus old (functions added by this PR):

["cba_fnc_fleximenu_highlightcaretkey","cba_fnc_fleximenu_keydown","cba_fnc_fleximenu_keyup","cba_fnc_fleximenu_list","cba_fnc_fleximenu_mousebuttondown","cba_fnc_fleximenu_getmenudef","cba_fnc_fleximenu_menu","cba_fnc_fleximenu_getmenuoption","cba_fnc_fleximenu_execute","cba_fnc_fleximenu_menushortcut"]
  1. Should we add all these new functions?
  2. cba_ui_fnc_setobjectmenusource has to be kept.

@dedmen
Copy link
Copy Markdown
Contributor Author

dedmen commented Feb 10, 2019

@commy2
Copy link
Copy Markdown
Contributor

commy2 commented Feb 10, 2019

idk, dude, it's the flexi menu dude

@commy2
Copy link
Copy Markdown
Contributor

commy2 commented Feb 11, 2019

What about not doing the = stuff and instead to make use of CfgFunctions with a different tag?
https://community.bistudio.com/wiki/Arma_3_Functions_Library#Tag

@dedmen
Copy link
Copy Markdown
Contributor Author

dedmen commented Feb 11, 2019

We need some of them twice anyway as they were defined in CfgFunctions and as a PREP with different names.

@commy2
Copy link
Copy Markdown
Contributor

commy2 commented Feb 11, 2019

What I don't want is to introduce new (duplicate) globals with this PR if it can be avoided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants