Skip to content

fix error popup in Arsenal Garage #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
commy2 merged 2 commits into from
Mar 9, 2019
Merged

fix error popup in Arsenal Garage #1094

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5020c13
fix error popup in Arsenal Garage
commy2 Mar 9, 2019
36e42b4
auto update version number
commy2 Mar 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions addons/ai/CfgVehicles.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ class CfgVehicles {
class B_TargetSoldier;
class CBA_B_InvisibleTarget: B_TargetSoldier {
scope = 2;
scopeArsenal = 0;
model = QPATHTOF(InvisibleTarget.p3d);
icon = "CBA_iconInvisibleTarget";

Expand All @@ -11,6 +12,7 @@ class CfgVehicles {
class O_TargetSoldier;
class CBA_O_InvisibleTarget: O_TargetSoldier {
scope = 2;
scopeArsenal = 0;
model = QPATHTOF(InvisibleTarget.p3d);
icon = "CBA_iconInvisibleTarget";

Expand All @@ -20,6 +22,7 @@ class CfgVehicles {
class I_TargetSoldier;
class CBA_I_InvisibleTarget: I_TargetSoldier {
scope = 2;
scopeArsenal = 0;
model = QPATHTOF(InvisibleTarget.p3d);
icon = "CBA_iconInvisibleTarget";

Expand Down
4 changes: 1 addition & 3 deletions addons/main_a3/CfgMods.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,13 @@ class CfgMods {
class PREFIX {
author = "$STR_CBA_Author";
dir = "@CBA_A3";
name = "Community Base Addons v3.9.1";
Copy link
Copy Markdown
Contributor

@PabstMirror PabstMirror Mar 9, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change it to 0.0.0
there is code to change on build
https://github.com/CBATeam/CBA_A3/blob/master/tools/make.py#L77
versionFiles = ["mod.cpp","addons\main_a3\CfgMods.hpp"]
https://github.com/CBATeam/CBA_A3/blob/master/tools/make.py#L597

Copy link
Copy Markdown
Contributor Author

@commy2 commy2 Mar 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = "Community Base Addons v3.9.1";
name = "Community Base Addons v0.0.0";

Like this?

Copy link
Copy Markdown
Contributor

@PabstMirror PabstMirror Mar 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, also need to change
https://github.com/CBATeam/CBA_A3/blob/master/tools/make.py#L77
versionFiles = ["mod.cpp","addons\main_a3\CfgMods.hpp"]

name = "Community Base Addons";
picture = "x\cba\addons\main\logo_cba_ca.paa";
hidePicture = 1;
hideName = 1;
actionName = "Website";
action = "$STR_CBA_URL";
description = "Bugtracker: https://github.com/CBATeam/CBA_A3/issues<br/>Documentation: https://github.com/CBATeam/CBA_A3/wiki";
logo = "logo_cba_ca.paa";
Copy link
Copy Markdown
Member

@jonpas jonpas Mar 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works if you have the logo inside a PBO as well, not just root of @mod folder.

logoOver = "logo_cba_ca.paa";
tooltip = "Community Base Addons";
tooltipOwned = "Community Base Addons Owned";
overview = "What does the name Community Base Addons mean? It is a system that offers a range of features for addon-makers and mission designers. This includes a collection of community-built functions, an integrated keybinding system, and extend event-handler support for compatibility with other 3rd-party addons; and much much more.";
Expand Down