Skip to content

createPerFrameHandlerObject - remove pfeh if location deleted#1306

Merged
commy2 merged 2 commits intomasterfrom
nullLocationsTellNoTales
Mar 13, 2020
Merged

createPerFrameHandlerObject - remove pfeh if location deleted#1306
commy2 merged 2 commits intomasterfrom
nullLocationsTellNoTales

Conversation

@PabstMirror
Copy link
Copy Markdown
Contributor

@PabstMirror PabstMirror commented Mar 12, 2020 •
edited
Loading

If location doesn't exist, then you won't get a valid getVar from it

x = [{systemChat str time}, 1] call CBA_fnc_createPerFrameHandlerObject

deleteLocation x

count cba_common_perFrameHandlerArray does not decrease

Edit: This would be a rare bug, CBA_fnc_deletePerFrameHandlerObject was safe

@commy2 commy2 added this to the 3.15 milestone Mar 12, 2020
@commy2 commy2 self-assigned this Mar 12, 2020
@commy2 commy2 added the Bug Fix label Mar 12, 2020
commy2
commy2 reviewed Mar 13, 2020
View reviewed changes
Comment thread addons/common/fnc_createPerFrameHandlerObject.sqf Outdated
@PabstMirror @commy2
Update addons/common/fnc_createPerFrameHandlerObject.sqf
686ca7c 
Co-Authored-By: commy2 <commy-2@gmx.de>
@commy2 commy2 merged commit 0a83503 into master Mar 13, 2020
@commy2 commy2 deleted the nullLocationsTellNoTales branch March 13, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@commy2 commy2 commy2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@commy2 commy2

Labels

Bug Fix

Projects

None yet

Milestone

3.15

Development

Successfully merging this pull request may close these issues.

2 participants

@PabstMirror @commy2