Common - Optimize and expand CBA_fnc_addWeaponWithoutItems#1557
Merged
jonpas merged 5 commits intoCBATeam:masterfrom Sep 7, 2023
Merged
Common - Optimize and expand CBA_fnc_addWeaponWithoutItems#1557jonpas merged 5 commits intoCBATeam:masterfrom
CBA_fnc_addWeaponWithoutItems#1557jonpas merged 5 commits intoCBATeam:masterfrom
Conversation
commy2
reviewed
Sep 16, 2022
Contributor
|
See: #1558 (comment) |
Contributor
Author
Would this PR be accepted, if |
3 tasks
Contributor
Author
|
I reverted the changing of |
jonpas
approved these changes
Sep 6, 2023
CBA_fnc_addWeaponWithoutItems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
removeAllSecondaryWeaponItemsand)compatibleMagazinesI can understand if the 2nd change is not wanted and considered to go against the rules.
Despite that, I think it has it's uses - being able to spawn in a weapon (with attachments or not) without it consuming a magazine from the inventory is really nice.
If it's not wanted, I'll just all related changes, but keep the updated commands (compatibleMagazinesis about 4x faster thanCBA_fnc_compatibleMagazines).