Common - Improve CBA_fnc_addItem, Fix CBA_fnc_addMagazine return#1562
Merged
jonpas merged 2 commits intoCBATeam:masterfrom Jun 24, 2023
Drofseh:Common-improve-CBA_fnc_addItem
Merged
Common - Improve CBA_fnc_addItem, Fix CBA_fnc_addMagazine return#1562jonpas merged 2 commits intoCBATeam:masterfrom Drofseh:Common-improve-CBA_fnc_addItem
jonpas merged 2 commits intoCBATeam:masterfrom
Drofseh:Common-improve-CBA_fnc_addItem
Conversation
Attempt to add the item to the unit's vehicle instead of always chucking it out the window onto the ground.
commy2
reviewed
Nov 24, 2022
Contributor
commy2
left a comment
commy2
left a comment
There was a problem hiding this comment.
Changes rv from false to true when dropping items on the ground as far as I can tell.
Contributor
Author
Should change it from always returning false to returning whatever CBA_fnc_addItemCargo returns if it is called, so true if it went somewhere basically. |
Contributor
|
Yes, because it breaks the behaviour documented in the functions header, and then also fix #1527 |
Contributor
Author
|
Done and done |
Drofseh
changed the title
jonpas
changed the title
jonpas
approved these changes
Jun 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Improve CBA_fnc_addItem
If the unit doesn't have enough space then try to add the item to the unit's vehicle instead of always chucking it out the window onto the ground where it gets lost.