Merged
Conversation
Contributor
|
I can not reproduce the problem that this PR supposedly solves. An action for which the assigned key is unbound (deleted) is shown as...well, nothing in the "Assigned keys" column in the configuration dialog. |
Contributor
Author
Member
|
@Killswitch00 If there is only one key unbound in the category it will show up empty (this is fine), but due to empty actually being it's own "key" it will show up as a duplicate bind when having more empty binds. |
Contributor
|
Thanks for the explanation and screenshot. |
Member
|
👍 |
Contributor
|
As mentioned elsewhere, how about displaying unbound keys as they are displayed in the normal game key assingment dialog, ie with the assigned key field empty? (As PabstMirror said, it would save us the trouble of translating the [UNBOUND] string) |
Fix private and mark dikCode -1 or 0 as unbound Just show blank space for unbound keys Formatting
d95f32d to
9b512ee
Compare
Killswitch00
added a commit
that referenced
this pull request
Nov 30, 2015
Show when a keybind is unbound
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Before it would show all unbound keys as duplicates (red)